1709508 - macOS high contrast mode is always light

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P2)

Description

[Mark Striemer [:mstriemer]]

Attachment: image.png

When macOS is in dark mode and Firefox is in the system/dark theme then about: pages, infobars and modals all appear with light colouring. This worked pre-proton and is likely happening since we use the system colours, but they aren't set or aren't set to dark colours by the OS. [1]

STR

1. Enable macOS dark mode
2. Enable "Increase contrast" in Accessibility
3. Check about:preferences, infobars, modals

Originally reported in bug 1700983 comment 4.

[1] https://searchfox.org/mozilla-central/rev/2f109387cc6886859d3f985ed9aca352fff653b8/toolkit/themes/shared/in-content/common.inc.css#234-235

Comment 1

[Markus Stange [:mstange]]

(In reply to Mark Striemer [:mstriemer] from comment #0)

This worked pre-proton and is likely happening since we use the system colours, but they aren't set or aren't set to dark colours by the OS. [1]

That's right - on macOS, CSS system colors currently do not observe system dark mode. But once bug 1623686 is done, they will - you can try this by setting widget.macos.respect-system-appearance to true locally.
However, while the text correctly turns white with that pref, the background remains white, too! It looks like -moz-Dialog, which is used for the background, resolves to rgba(255, 255, 255, 0.098) in dark mode. This is a very low-opacity white color, rather than an opaque dark color. It seems to be intended to be used on top of a dark backdrop.

Comment 2

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #1)

However, while the text correctly turns white with that pref, the background remains white, too! It looks like -moz-Dialog, which is used for the background, resolves to rgba(255, 255, 255, 0.098) in dark mode. This is a very low-opacity white color, rather than an opaque dark color. It seems to be intended to be used on top of a dark backdrop.

I've filed bug 1710164 about this.

Comment 3

[Micah [:mtigley] (she/her)]

This looks to be fixed recently, perhaps by bug 1623686? Mark, are you still able to reproduce the issue?

Comment 4

[Mark Striemer [:mstriemer]]

Looks fixed to me, thanks!