1712225 - Remove fixed position on search bar on scroll

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, enhancement, P3)

Comment 1

[Amy Churchwell [:amy]]

Attachment: animated gif of desired search bar behavior

Comment 2

[Amy Churchwell [:amy]]

Currently, when scrolling on the new tab page the search bar changes from being inline on the page to a fixed position at the top. This bug is to remove that behavior. See gif attachment for a visual spec.

Comment 3

[Falguni Islam]

Hello I am an accepted outreachy applicant I am looking for good first bug can I work on this bug?

Comment 4

[onuohaoluebube05]

Hello, I want to contribute to this project.

Thanks

Comment 5

[Amy Churchwell [:amy]]

(In reply to Falguni Islam from comment #3)

Hello I am an accepted outreachy applicant I am looking for good first bug can I work on this bug?

Hi there! I assigned you to bug 1709204, were you wanting to work on multiple bugs?

Comment 6

[onuohaoluebube05]

Hello Amy, I am an outreachy applicant too.

I would love to be assigned to work on this bug.

Comment 7

[Amy Churchwell [:amy]]

(In reply to onuohaoluebube05 from comment #6)

Hello Amy, I am an outreachy applicant too.

I would love to be assigned to work on this bug.

Hello! Seeing as Falguni has a bug they are working on, let's assign this one to you. Don't hesitate to let me know if you have any questions.

Please note that you will have to bundle the CSS before you can see your changes on the new tab page. Run ./mach npm run bundle --prefix=browser/components/newtab. More information here.

Comment 8

[onuohaoluebube05]

Thanks Amy

Comment 9

[onuohaoluebube05]

Hello Amy,
I am getting an error running this "./mach npm run bundle --prefix=browser/components/newtab ".

What could be the cause?

Thanks

Comment 10

[onuohaoluebube05]

Resolved

Comment 11

[onuohaoluebube05]

Hello Amy

When I build the browser on my system it appear like this
Behavior on my system

The gif you posted is it the current behavior or the desired behavior?

Comment 12

[Amy Churchwell [:amy]]

Hi onuohaoluebube05!

The gif posted is the desired behavior. Locally, I am still seeing the fixed position behavior we are looking to remove.
We can investigate further.

Just to make sure we are on the same page, will you double-check that you are on the latest central?

1. Pull and update your local central: hg up central && hg pull central && hg update
2. To build Firefox and run new tab: ./mach npm run bundle --prefix=browser/components/newtab && ./mach build && ./mach run

Also, what operating system are you using?

Comment 13

[onuohaoluebube05]

Hello Amy,

Thanks for your response

I am using windows operating system.

I updated my local central.

From what i can get, i should set focus to the topmost search bar as the the second search bar scrolls out of view?

Thanks

Comment 14

[onuohaoluebube05]

Hello Amy,

Thanks for your response

I am using windows operating system.

I updated my local central.

From what i can get, i should set focus to the topmost search bar as the the second search bar scrolls out of view?

Thanks

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P1'.
:daleharvey, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 16

[Anthony Hung]

Hi Amy,

From the animated gif, I know the desired search bar behaviour when the search input is empty and in focus.

But what if there is some character typed in the urlbar or search bar, should the input content transfer to the other bar and clear the content?

If the search bar is not focused, will the urlbar set to focus after the search bar is not visible?

Also, there are 2 search bar modes in newtab page, the default one is a fake button and the other one is a real search bar. Are they both have the same behaviour?

What are the behaviours of all the above cases?

Comment 17

[Dale Harvey (:daleharvey)]

At a guess, this only applies to the "fake" search box that hands off to the urlbar. That search box will not have content only the urlbar

Comment 18

[Anthony Hung]

(In reply to Dale Harvey (:daleharvey) from comment #17)

At a guess, this only applies to the "fake" search box that hands off to the urlbar. That search box will not have content only the urlbar

But now the default focus is on the url bar. It needs to change to default focus on search box?

Comment 19

[Mihir Nayak]

is this bug assigned to someone?

Comment 20

[aritra :ari]

It's my first time here. Can I try to solve the bug?

Comment 21

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1712225 - Remove fixed position on search bar on scroll r=daleharvey

Comment 22

[Dale Harvey (:daleharvey)]

Many thanks for the patch Jonathan

Scott this is far more involved in the Activity Stream code than I could handle reviewing, is there any chance you could find someone suitable?

Thanks

Comment 23

[Scott [:thecount] Downe]

Amy, do you want to review this? Code looks to be doing the right things, but I am not really familiar with the specifics of search.

Comment 24

[Ed Lee :Mardak]

Do we believe there won't be much change in user engagement with the search box that might have been the original intent behind bug 1481677?

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:daleharvey, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit auto_nag documentation.

Comment 26

[Amy Churchwell [:amy]]

Hi Jim, wanted to check in to see if we need signoff for this change? There was some confusion about whether we still intend to ship this or not.

Comment 27

[Amy Churchwell [:amy]]

Closing all remaining bugs under https://bugzilla.mozilla.org/show_bug.cgi?id=1707989 per request from product.