Closed Bug 1718097 Opened 4 years ago Closed 4 years ago

Connection dialog says DoH is not enabled, when it is enabled via Remote Settings

Categories

(Firefox :: Settings UI, defect)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- verified
firefox91 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Missed this in bug 1713036.
In the Connection dialog, we should use DoHConfigController.currentConfig.enabled instead of doh-rollout.enabled

[Tracking Requested - why for this release]:

This is a bug :-)
We should make sure this is fixed in 91.

Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Keywords: regression
Regressed by: 1713036
Summary: In the Connection dialog, use DoHConfigController.currentConfig.enabled instead of doh-rollout.enabled → Connection dialog says DoH is not enabled, when it is enabled via Remote Settings
Has Regression Range: --- → yes

In bug 1713036, I modified the DoH preferences code to look at DoHConfigController.currentConfig for state. This will get us the values actually in use, sourced from prefs + Remote Settings. I missed changing over this one pref to that new system.

(In reply to Nihanth Subramanya [:nhnt11] from comment #1)

[Tracking Requested - why for this release]:

This is a bug :-)
We should make sure this is fixed in 91.

It'd be pretty useful to understand how this impacts users and/or usage/rollout of DoH.

Flags: needinfo?(nhnt11)

(In reply to :Gijs (he/him) from comment #4)

(In reply to Nihanth Subramanya [:nhnt11] from comment #1)

[Tracking Requested - why for this release]:

This is a bug :-)
We should make sure this is fixed in 91.

It'd be pretty useful to understand how this impacts users and/or usage/rollout of DoH.

Users in the rollout would see that DoH is not enabled when viewing their connection settings, and may try to enable it manually which will unenroll them from the rollout. However, they'll still have DoH, just without heuristics.

Generally the fact that heuristics aren't really exposed in the UI is a larger issue that product is working on for H2.

Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4121b27f9dfc Use DoHConfigController.currentConfig.enabled instead of doh-rollout.enabled in about:preferences. r=preferences-reviewers,mstriemer
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Set release status flags based on info from the regressing bug 1713036

Depends on: 1720379

Comment on attachment 9228834 [details]
Bug 1718097 - Use DoHConfigController.currentConfig.enabled instead of doh-rollout.enabled in about:preferences. r=#preferences-reviewers!

Beta/Release Uplift Approval Request

  • User impact if declined: This uplift is in support of unblocking our rollout of DoH in Canada. The patches for which uplift is being requested update the DoH settings UI to work better with Remote Settings, and simplify the Normandy recipe for the rollout.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1713036, Bug 1720379, Bug 1718097, Bug 1719851, Bug 1714486
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): The changes have been baking for a while and work well. Medium risk because of the number of patches we need to uplift.
  • String changes made/needed:
Attachment #9228834 - Flags: approval-mozilla-release?
  • We verified this issue across platforms (Windows 10 x64, Ubuntu 20 x64, macOS 11.4) using the 90.0.2 try-build provided by Nihanth.
  • We performed smoke testing using the Remote Settings Stage environment on the DoH Preferences UI and didn't encounter any issues.
  • After enrolling in the Canada experiment, we verified that the CIRA (Canadian DNS provider) was already enabled by default.

Comment on attachment 9228834 [details]
Bug 1718097 - Use DoHConfigController.currentConfig.enabled instead of doh-rollout.enabled in about:preferences. r=#preferences-reviewers!

approved for 90.0.2

Attachment #9228834 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: