1718492 - "Spellcheck As You Type" gets disabled when saving composition as draft or template

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P2)

Description

[Leo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_4_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.192 Safari/537.36

Steps to reproduce:

Case:
"Enable spellcheck as you type" is checked in Preferences
When creating a new message, the Options > Spellcheck As You Type menu is checked.
BUT once you Save email, it becomes unchecked and spelling is not checked.
If you enable the menu manually, it will be unchecked on next Save again.

Actual results:

please see above

Expected results:

please see above

Comment 1

[Thomas D. (:thomas8)]

Thanks Leo, sounds weird but it does happen exactly as described - not useful! This makes Spellcheck as you type a no-op. Should fix this asap.

Confirmed 91.0a1 (2021-06-28) (64-bit), Win10 (IMAP and POP).

Comment 2

[Thomas D. (:thomas8)]

Alice, could you kindly find the regression range?

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=d753b6013e03421b1c816e8bc810dc808e221b2b&tochange=3b1645fde19a14562753ff374fee690e3ca0ffde
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=478d2e18554dfcdde9876073614a2c4973cb6e1c&tochange=46580fa5a4ce20c8cf1c7c9f3f520a1e9c644518

Comment 4

[Thomas D. (:thomas8)]

(In reply to Alice0775 White from comment #3)

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=d753b6013e03421b1c816e8bc810dc808e221b2b&tochange=3b1645fde19a14562753ff374fee690e3ca0ffde

Wow, thanks Alice, that's awesome!

So looks like we've jumped out of the frying pan into the fire:
Regressed by Bug 1695923 - Unchecked 'Spellcheck As You Type' turns back on when saving message as draft

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1718492 - Remember the spell checking state independently of the checker itself. r=mkmelin

Asking the spell checker if it should be enabled is unreliable as it's affected by too many things. Instead, let's just keep track of whether spell checking is enabled or not.

Comment 6

[Geoff Lankow (:darktrojan)]

What a mess. The editor's got a spell checking flag, but it changes when things unrelated to spell checking happen. I've given up relying on it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd0e2b4c8c96
Remember the spell checking state independently of the checker itself. r=mkmelin