1720725 - email will not send - chokes on the spellchecker being not initialized

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[musiquegraeme]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

I clicked on Send

Actual results:

The send, spelling and save buttons were greyed out and that was that.

Expected results:

The email should have been sent.
The solution was to remove my addon but this has come as a result of TB91 which came today. I can't find any change listed anywhere that will explain this error and there is no consistent message in the Addon debugger to explain it.
It seems that there is a change unreported in the onBeforeSend function.

Comment 1

[musiquegraeme]

You might say - fix the addon but I rely on knowing what changes have been made. The addon is SingleDomain. There is a small experimental part of that but removing that made no difference.

Comment 2

[John Bieling (:TbSync)]

It is not an error in his add-on, but it chokes on the spellchecker being not initialized. That is new.

Comment 3

[Wayne Mery (:wsmwk)]

Sorry, I misunderstood comment 1

Comment 4

[John Bieling (:TbSync)]

Regressed by https://phabricator.services.mozilla.com/D118994

STR:

• install https://addons.thunderbird.net/addon/single-domain/
• write an email (does not matter where to)
• hit the send button
  -> buttons gray out and nothing happens
  -> error message about spellchecker not (no longer?) being initialized

Comment 5

[musiquegraeme]

Just to respond to this - I do have Spell checker initialised - it checks as I type. So I'm not sure how this setting is really affecting the sending of emails.. Hate to disagree but just wanting to be clear.

Comment 6

[John Bieling (:TbSync)]

I was unclear. Spell checking in the UI while composing is working, but the core spellchecker component is no longer initialized when the onBeforeSendEvent calls setComposeDetails() (or something), which triggers some spellchecker related stuff.

That is at least what I see on the error console and what needs to be fixed. Could of course be that you see another bug, which we can check after this issue has been fixed.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1720725 - Fix setting compose details from an onBeforeSend listener. r=john.bieling

Reverts a change made in bug 1718492.

Comment 8

[Geoff Lankow (:darktrojan)]

This fixes things, as far as I can tell.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c44225a8394
Fix setting compose details from an onBeforeSend listener. r=john.bieling

Comment 10

[John Bieling (:TbSync)]

Comment on attachment 9232072 [details]
Bug 1720725 - Fix setting compose details from an onBeforeSend listener. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
The onBeforeSend event cannot be used.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9232072 [details]
Bug 1720725 - Fix setting compose details from an onBeforeSend listener. r=john.bieling

[Triage Comment]
Approved for beta

Comment 12

[musiquegraeme]

Updated to 91.0b2 and it doesn't seem to have changed at all... Should it have or is it going to be in the next beta?

Comment 13

[John Bieling (:TbSync)]

Next Beta. You can test it in Daily though.

Comment 14

[Dave Miller [:justdave]]

Thunderbird 910b3:
https://hg.mozilla.org/releases/comm-beta/rev/9c6d5a907659

Comment 15

[John Bieling (:TbSync)]

I have reports this not being fixed on 91.0 release. Will test more. Maybe we should back out this fix and the original cause for this fix (https://phabricator.services.mozilla.com/D118994)

The TopicBox report started with a different error but eventually ended up here:
https://thunderbird.topicbox.com/groups/addons/T90f2914acf15917b-Me8d07197be3c046d900aa88e/mx-fails-in-91-promise-rejected-after-context-unloaded

Comment 16

[Wayne Mery (:wsmwk)]

For completeness in this tangled web, the working theory for bug bug 1721801 (reported 2021-07-22) is the regressor is bug 1311934, landed on nightly 2021-07-19.

ANd this bug reported 2021-07-15 predates bug 1311934.

Comment 17

[Geoff Lankow (:darktrojan)]

It all seems to be working fine in 91 for me. I tried a bunch of likely things and couldn't fault it. Let's not confuse the issue further by backing stuff out.

Comment 18

[John Bieling (:TbSync)]

TB91 still breaks on the onBeforeSend event, if the user has no dictionary installed. You can reproduce this by downloading:
https://download.mozilla.org/?product=thunderbird-91.0.1-SSL&os=linux64&lang=en-GB