1719735 - Unify DisplayNames in SpiderMonkey

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

https://searchfox.org/mozilla-central/source/js/src/builtin/intl/DisplayNames.cpp

Most likely a mozilla::intl::DisplayNames needs to be created.

Comment 1

[Greg Tatum [:gregtatum]]

I have a local patch starting this, and I think it's going to have to depend on LanguageTags (Bug 1719746) as there is significant usage of that class here. With the fallbacking behavior, it's hard to negotiate the string usage. I would prefer the unified API just providing the final result and handling language tag canonicalization internally.

I've gone back and forth a bit on the design, and I think it will be simpler to not do it incrementally like I'm trying.

Comment 2

[Greg Tatum [:gregtatum]]

WIP Patch: https://gist.github.com/gregtatum/d21c427268f10619b60d71c282b4fb9b

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719735 - Add a UTF-16 span overload for FillBuffer; r?#platform-i18n-reviewers!

Depends on D129662

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719735 - Create a unified DisplayNames API; r?#platform-i18n-reviewers!

Depends on D130798

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719735 - Use mozilla::intl::DisplayNames in SpiderMonkey; r?#platform-i18n-reviewers!

Depends on D130799

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719735 - Have IcuLocale take a null-terminated Span; r?#platform-i18n-reviewers!

This simplifies the call sites that take Span locale, and ensures null
termination.

Comment 7

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719735 - Switch DateTimePatternGenerator to use a Span for locales; r?#platform-i18n-reviewers!

Depends on D131668

Comment 8

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719735 - Naively rename intl/locale/DateTimeFormat to AppDateTimeFormat; r?#platform-i18n-reviewers!

This will not build, but will provide a better diff for the changes.

Depends on D131669

Comment 9

[Phabricator Automation]

Comment on attachment 9251640 [details]
Bug 1719735 - Naively rename intl/locale/DateTimeFormat to AppDateTimeFormat; r?#platform-i18n-reviewers!

Revision D131670 was moved to bug 1715892. Setting attachment 9251640 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48f398e301f
Have IcuLocale take a null-terminated Span; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/8fcdcdf44b62
Add a UTF-16 span overload for FillBuffer; r=platform-i18n-reviewers,dminor

Comment 11

[Greg Tatum [:gregtatum]]

I'm only landing the first pieces of approved patches which Bug 1715892 is using. I still need review on the rest of the patch stack.

Comment 12

[Marian-Vasile Laza]

Backed out 6 changesets (Bug 1715892, Bug 1719735) for causing bc test failures.
Backout link
Push with failures
Failure Log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f74c12da7ebd
Have IcuLocale take a null-terminated Span; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/a1c8cccb360f
Add a UTF-16 span overload for FillBuffer; r=platform-i18n-reviewers,dminor

Comment 14

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/f74c12da7ebd
https://hg.mozilla.org/mozilla-central/rev/a1c8cccb360f

Comment 15

[Greg Tatum [:gregtatum]]

I landed the first part of the patch stack with Bug 1715892 while waiting for the final reviews on the DisplayNames patches.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aba21720cc4
Create a unified DisplayNames API; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/597a8b16df5c
Use mozilla::intl::DisplayNames in SpiderMonkey; r=dminor

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0aba21720cc4
https://hg.mozilla.org/mozilla-central/rev/597a8b16df5c