1723628 - Handle fallout from bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Geoff Lankow (:darktrojan)]

M-C landed a change which crashes the tests if we attempt to load a URL that doesn't exist. Of course that's something we do.

Comment 1

[Geoff Lankow (:darktrojan)]

I'm going to push a change to un-bust the tests, then post a patch or two here to clean up the mess.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/03539b669fb8
Fix crash on requests to non-existing chrome: and resource: files on infra (bug 1721627). rs=bustage-fix

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1723628 - Stop loading AttributionCode.jsm outside of Firefox. r=nalexander

This code ultimately loads resource:///modules/AttributionCode.jsm which only exists in Firefox. It's now causing test crashes in Thunderbird due to bug 1721627, or it was, but I've temporarily hacked them into working.

Comment 4

[:Gijs (he/him)]

The AttributionCode thing also hits android, and so I added an exception for it, but this patch seems like a plausible way of addressing it (though per the discussion in bug 1722082 I think there's some confusion about what bits of telemetry run where that may be good to resolve at a higher level - I'm not sure yet...)

Comment 5

[Geoff Lankow (:darktrojan)]

Ah, I didn't know bug 1722082 was a thing. I found that loading AttributionCode was conditionally turned off elsewhere in the same file, so I've done the same thing here. Hopefully that doesn't make a mess of what you're working on.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a349aee25be1
Stop loading AttributionCode.jsm outside of Firefox. r=chutten

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a349aee25be1

Comment 8

[:Gijs (he/him)]

(In reply to Geoff Lankow (:darktrojan) from comment #5)

Ah, I didn't know bug 1722082 was a thing. I found that loading AttributionCode was conditionally turned off elsewhere in the same file, so I've done the same thing here. Hopefully that doesn't make a mess of what you're working on.

Nope, this is great, thank you!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/799588135781
Stop shipping AttributionCode.jsm. rs=me