1724753 - Envelope / Mail folder icon below Menu Bar changes to an Adobe icon

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Arthur K. (he/him)]

Attachment: Adobe Prelude will be discontinued, effective September 8, 2021..eml

I received an email from Adobe and when I clicked on it, I noticed that the envelope icon that normally appears to the left on the tab which shows what current folder is selected (in my case, Inbox) tuns into an Adobe icon. It stays as an Adobe icon instead of an envelope icon even if I read other emails in my Inbox. The only way to change it back to an envelope icon is to click on another folder.

STR:

I attached the offending email as an .eml file. Hope it repros for you.

Comment 1

[Arthur K. (he/him)]

Attachment: adobe-replaces-icon.png

Here's a screenshot of what I am talking about.

Comment 2

[Geoff Lankow (:darktrojan)]

That's cheeky. I know what caused this, I think.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1724753 - Only use icons from content in content tabs. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0451e8964a5a
Only use icons from content in content tabs. r=mkmelin

Comment 6

[alta88]

The string is "contentTab".

Issue the following and make sure it sets a tab favicon:
openContentTab("https://hacks.mozilla.org/2019/03/firefox-66-the-sound-of-silence/", "tab").

Also, why wouldn't you implement the browser LinkHandlerParent exactly instead of the halfway thing in mail; isn't it a laudable goal to get rid of the tabmail stuff (setting busy eg) as much as possible eventually in favor of a real tab infrastructure? Isn't every tab going to be a contentTab (answer should be yes).

Comment 7

[Geoff Lankow (:darktrojan)]

(In reply to alta88 from comment #6)

The string is "contentTab".

Damn. So it is.

Also, why wouldn't you implement the browser LinkHandlerParent exactly instead of the halfway thing in mail; isn't it a laudable goal to get rid of the tabmail stuff (setting busy eg) as much as possible eventually in favor of a real tab infrastructure? Isn't every tab going to be a contentTab (answer should be yes).

Maybe at some point. Right now I'm here to fix a bug.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/afa4105ab047
follow-up - Use the right string value. rs=me

Comment 9

[Uplift Request]

Please request 92 (and later 91) uplift.

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9235724 [details]
Bug 1724753 - Only use icons from content in content tabs. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1721272
User impact if declined: content of email messages can change the 3-pane tab icon
Testing completed (on c-c, etc.): landed a broken patch last week, added a fix the next day (there are two changes to uplift)
Risk to taking this patch (and alternatives if risky): minor

Comment 11

[Geoff Lankow (:darktrojan)]

(In reply to Uplift Request from comment #9)

Please request 92 (and later 91) uplift.

Please stop doing that. I am capable of making my own decisions about patches being uplifted.

Comment 12

[Uplift Request]

Very well. Can you suggest a system to reliably make sure that uplifts happen for all other developers? For example, bug 1722097 and bug 1706918 didn't even have a target milestone set, not to mention status flags. Backport apparently forgotten in bug 1719265 and bug 1633792 and likely a few more.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9235724 [details]
Bug 1724753 - Only use icons from content in content tabs. r=mkmelin

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 92.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e70d9120a448
https://hg.mozilla.org/releases/comm-beta/rev/2c40002efda8

Comment 15

[Geoff Lankow (:darktrojan)]

Comment on attachment 9235724 [details]
Bug 1724753 - Only use icons from content in content tabs. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1721272
User impact if declined: content of email messages can change the 3-pane tab icon
Testing completed (on c-c, etc.): in 92.0b2
Risk to taking this patch (and alternatives if risky): minor

(two patches, because I am an idiot)

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9235724 [details]
Bug 1724753 - Only use icons from content in content tabs. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 91.0.3:
https://hg.mozilla.org/releases/comm-esr91/rev/b62afc131bde
https://hg.mozilla.org/releases/comm-esr91/rev/911809e76993