1725926 - Thunderbird appears with dark theme even when desktop environment is using non-dark theme

Status: NEW

(Thunderbird :: Theme, defect)

Description

[Asif Youssuff]

On Ubuntu Impish Indri (development branch) and GNOME 40.2.0

Was previously using Adwaita-dark, currently using Adwaita.

Thunderbird now appears in a dark theme. The theme was previously working based on my GTK theme.

regression window:

4:23.72 INFO: Last good revision: e7dd7edf03c9643ff52f4eb3474355669968eee7
4:23.72 INFO: First bad revision: 9473904d2047fc7d42476625eb8f4cf8d5a6f11f
4:23.72 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e7dd7edf03c9643ff52f4eb3474355669968eee7&tochange=9473904d2047fc7d42476625eb8f4cf8d5a6f11f

Comment 1

[Asif Youssuff]

Attachment: about:support

Comment 2

[Asif Youssuff]

Attachment: Screenshot from 2021-08-16 03-09-44.png

Comment 3

[Magnus Melin [:mkmelin]]

Those comm-central checkins could not have caused it. Maybe something from mozilla-central

Comment 4

[Asif Youssuff]

I took a look at about:config and noticed that ui.systemUsesDarkTheme was set to 1. I deleted the key and Thunderbird immediately showed my correct theme.

I then switched to a different (dark) theme, which caused the UI to change to a darker UI, correctly. After restart, the correct (dark) theme persisted. However, switching back to a light theme showed the same issue as reported, and ui.systemUsesDarkTheme was set to 1. Restarting Thunderbird made no difference.

It seems that Thunderbird's dark theme detection happens then never checks itself to see if it is still correct.

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Asif Youssuff from comment #4)

I took a look at about:config and noticed that ui.systemUsesDarkTheme was set to 1. I deleted the key and Thunderbird immediately showed my correct theme.

I then switched to a different (dark) theme, which caused the UI to change to a darker UI, correctly. After restart, the correct (dark) theme persisted. However, switching back to a light theme showed the same issue as reported, and ui.systemUsesDarkTheme was set to 1. Restarting Thunderbird made no difference.

It seems that Thunderbird's dark theme detection happens then never checks itself to see if it is still correct.

Is this still happening when using version 102?

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Asif Youssuff from comment #0)

On Ubuntu Impish Indri (development branch) and GNOME 40.2.0

Was previously using Adwaita-dark, currently using Adwaita.

Thunderbird now appears in a dark theme. The theme was previously working based on my GTK theme.

regression window:

4:23.72 INFO: Last good revision: e7dd7edf03c9643ff52f4eb3474355669968eee7
4:23.72 INFO: First bad revision: 9473904d2047fc7d42476625eb8f4cf8d5a6f11f
4:23.72 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e7dd7edf03c9643ff52f4eb3474355669968eee7&tochange=9473904d2047fc7d42476625eb8f4cf8d5a6f11f

Some items stand out in https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2021-06-10&enddate=2021-06-11 :

• Bug 1715619 - Enable widget.macos.support-dark-appearance by default on Nightly and Early Beta
• Bug 1710164 - White-on-white text on in-content pages when using macOS Dark Mode + High Contrast Mode, if widget.macos.respect-system-appearance is enabled
• Bug 1707872 - Sidebar does not follow Firefox theme
• and Bug 1714885 - Cleanup css added for dark mode support in about debugging - but I don't see how that could be involved

Comment 7

[Asif Youssuff]

No longer seeing this in Thunderbird daily.