1727938 - Importing ICS file with TODO items fails with JS error

Status: RESOLVED FIXED

(Calendar :: Import and Export, defect, P2)

Description

[Zoe Martin]

Attachment: todo.ics

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Importing ICS file with TODO items fails with JS error.
Sample file enclosed.

Console error:
CalIcsParser.jsm:159
Uncaught (in promise) TypeError: b.startDate is undefined
setUpItemSummaries chrome://calendar/content/calendar-ics-file-dialog.js:149
setUpItemSummaries chrome://calendar/content/calendar-ics-file-dialog.js:148
onWindowLoad chrome://calendar/content/calendar-ics-file-dialog.js:78
loadEventsFromFile chrome://calendar/content/import-export.js:37
calendar-ics-file-dialog.js:149:5

https://searchfox.org/comm-central/rev/590a88f6af49f11b651fa305d94ff25f1211893d/calendar/base/content/dialogs/calendar-ics-file-dialog.js#149

Looks a bit like bug 155757.

Comment 1

[Zoe Martin]

https://github.com/Betterbird/thunderbird-patches/blob/main/91/bugs/1727938-sort-no-start-date.patch
We didn't pay attention to linting, this imports the ICS file we were given successfully.

Comment 4

[Thomas D. (:thomas8)]

Attachment: 1727938_import-vtodo-from-ics.diff

This fixes the issue for me - based on Zoe's patch. Thanks Zoe!

Comment 5

[Thomas D. (:thomas8)]

Obviously enterprise-relevant.

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9238597 [details] [diff] [review]
1727938_import-vtodo-from-ics.diff

There's more date values that could be tried before giving up:
https://searchfox.org/comm-central/rev/88d88aa4086176def5c63925b9d727b593ec6b99/calendar/base/modules/utils/calViewUtils.jsm#332-335

I also don't like the variable names here, because they don't relate to a and b.

Comment 9

[Magnus Melin [:mkmelin]]

Thomas, can you update the patch?

Comment 10

[Thomas D. (:thomas8)]

Attachment: 1727938_import-vtodo-from-ics.diff

Improve the comparison per Geoff's comment 6.

Thanks for the ping!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ac0a8151ac01
Fix import of ics with VTODOs (tasks) and sort items without start date to the end. r=darktrojan

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9245747 [details] [diff] [review]
1727938_import-vtodo-from-ics.diff

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: per bug summary
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9245747 [details] [diff] [review]
1727938_import-vtodo-from-ics.diff

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/2db3564a86d3

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9245747 [details] [diff] [review]
1727938_import-vtodo-from-ics.diff

[Triage Comment]
approved for esr91

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/d8f7a6691e7f