Closed Bug 1731652 Opened 1 year ago Closed 1 year ago

Localize theme variant names

Categories

(Firefox :: Theme, task, P1)

task
Points:
3

Tracking

()

RESOLVED FIXED
94 Branch
Iteration:
94.2 - Sep 20 - Oct 3
Tracking Status
firefox94 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

(Whiteboard: [fidefe-theme])

Attachments

(1 file)

We want to partially localize monochromatic theme names. They have two parts: the color name and the variant name. For example, one color is "Abstract" and one variant is "Balanced". We want to localize just the variant name, so the theme appears in about:addons with a name like (using French as an example): Abstract – Balancé.

Currently, we localize some theme names using a .properties file. Zibi thinks this is currently the only way to localize theme names, although work may be underway to support Fluent. Mardak points out that we could maybe add custom localization in bug 1729535, but I am concerned about maintainability in that case.

Review thread, for context: https://phabricator.services.mozilla.com/D125755#inline-692933

Whiteboard: [fidefe-theme]
Depends on: 1729738

Just mentioning for completeness, in case it helps:

WebExtensions (including themes) can have localized strings by bundling the translations in a _locales/ directory, as documented at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization

There are two downsides:

  • The format doesn't use Fluent, so all supported translations would be bundled with one XPI file, and be checked in as part of m-c (search for _locales/*/messages.json for some existing examples in m-c).
  • All locales are loaded when the extension/theme starts for the first time, which results in slightly more overhead in the initialization/installation of the extension at the first run. The result is cached, but the cache is cleared when the Firefox version changes.
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 94.2 - Sep 20 - Oct 3
Attachment #9243305 - Attachment description: WIP: Bug 1731652 - Localize theme variant names → Bug 1731652 - Localize theme variant names. r?robwu!
See Also: → 1733466
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2da5583be165
Localize theme variant names. r=fluent-reviewers,flod,extension-reviewers,robwu
See Also: → 1733552
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.