The user is not redirected to the Preferences Search pane after clicking the “Customize in preferences” modal button if other than Preferences Search pane is already opened in an existing tab
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
People
(Reporter: cfat, Assigned: adw)
References
Details
Attachments
(2 files)
1.07 MB,
image/gif
|
Details | |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-release+
|
Details | Review |
[Affected versions]:
- Firefox Beta 93.0b4 (Build ID: 20210912185727)
- Firefox Nightly 94.0a1 (Build ID: 20210913213224)
[Affected Platforms]:
- Windows 10 x64;
- macOS 10.15.7;
- Linux Ubuntu 20.04 x64;
[Prerequisites]:
- Have the Session restore enabled.
- Have the “about:preferences” page opened, with other than Search pane displayed (e.g. “Sync”).
[Steps to reproduce]:
- Open the Firefox browser with the profile from prerequisites.
- Set the following preferences:
browser.urlbar.quicksuggest.enabled: true
browser.urlbar.quicksuggest.scenario: online
browser.urlbar.quicksuggest.shouldShowOnboardingDialog: true
browser.urlbar.suggest.quicksuggest: false
browser.urlbar.suggest.quicksuggest.sponsored: false
- Restart the browser.
- Click the “Customize in settings” button from the Onboarding modal.
- Observe the behavior.
[Expected result]:
- The user is redirected to the already opened “about:preferences” page, with the Search pane in focus (Privacy pane after bug 1730580 lands).
[Actual result]:
- The user is redirected to the already opened “about:preferences” page, with the Sync pane in focus.
[Notes]:
- The following errors are displayed in the Browser Console when clicking the “Customize in settings” button from the Onboarding modal:
Nightly
[bug 1345098] Lazy browser prematurely inserted via 'loadURI' property access: getter@chrome://browser/content/tabbrowser.js:2271:39 switchIfURIInWindow@chrome://browser/content/browser.js:8634:11 switchToTabHavingURI@chrome://browser/content/browser.js:8657:26 openPreferences@chrome://browser/content/utilityOverlay.js:1045:20 maybeShowOnboardingDialog@resource:///modules/UrlbarQuickSuggest.jsm:265:11 tabbrowser.js:2271:25
TypeError: can't access property "gotoPref", browser.contentWindow is null
Beta
TypeError: browser.contentWindow is nullutilityOverlay.js:1064:5
- Attached is a screen recording of the issue.
Assignee | ||
Comment 1•3 years ago
|
||
This is most likely a bug in the preferences UI and not on our side, but I'm not 100% sure. Either way, to see the problem, you have to start up Firefox with restored tabs, and one of those tabs has to be about:preferences, and the onboarding has to be triggered, all at the same time. Not impossible but it seems like an uncommon scenario.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
When switching to an already open but lazy/unloaded about:preferences tab and
highlighting a section in it, wait for it to load first.
Assignee | ||
Comment 3•3 years ago
•
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e2af137faf913fb1b897a405ab53a0660cdc49a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=49bb4d5aeafbd5733e12aea11acfb26995df92c3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f453914cda8644c917b5f048a6b74963e777006a
https://treeherder.mozilla.org/jobs?repo=try&revision=f88af07990e38106ae56a0cbeefaff687d921960
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b8a4f25b257 When switching to an already open but lazy/unloaded about:preferences tab and highlighting a section in it, wait for it to load first. r=dao
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
Assignee | ||
Comment 6•3 years ago
|
||
Comment on attachment 9241256 [details]
Bug 1730702 - When switching to an already open but lazy/unloaded about:preferences tab and highlighting a section in it, wait for it to load first.
Beta/Release Uplift Approval Request
- User impact if declined: Needed for important Firefox Suggest rollouts on 93 and 92
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Should be clear from comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a small change that waits for about:preferences to load before trying to highlight a section in it.
- String changes made/needed:
Comment 7•3 years ago
|
||
Comment on attachment 9241256 [details]
Bug 1730702 - When switching to an already open but lazy/unloaded about:preferences tab and highlighting a section in it, wait for it to load first.
Needed for experiments targeting Fx92. Approved for 93.0b6.
Comment 8•3 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 9•3 years ago
|
||
I have verified that the issue is no longer reproducible on Firefox 94, for non-US region (RO, DE). The user is correctly redirected to the Privacy pane, with the Address Bar - Firefox Suggest section highlighted. Tested using Firefox Nightly 94.0a1 (Build ID: 20210916125444) on Windows 10, macOS 11.1, and Ubuntu 20.04 x64.
By setting the US region, the issue is still reproducible. In order to track the issue, I have logged Bug 1731104.
Updated•3 years ago
|
Reporter | ||
Comment 10•3 years ago
|
||
- I have verified that the issue is no longer reproducible on Firefox Beta 93.06 (Build ID: 20210916185649) for non-US region (RO, DE).
- The user is correctly redirected to the Privacy pane, with the Address Bar - Firefox Suggest section highlighted. Tested across platforms Windows 10, macOS 11.1, and Ubuntu 20.04 x64.
Comment 11•3 years ago
|
||
Comment on attachment 9241256 [details]
Bug 1730702 - When switching to an already open but lazy/unloaded about:preferences tab and highlighting a section in it, wait for it to load first.
Approved for 92.0.1.
Comment 12•3 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 13•3 years ago
|
||
-
I have verified this issue using the Candidate 92.0.1 build (Build ID: 20210920202613) on Windows 10 x64, macOS 10.15.7 and Linux Ubuntu 20.04 x64.
-
The user is correctly redirected to the Privacy pane, with the Address Bar - Firefox Suggest section highlighted. Tested with non-US region (ro).
Description
•