1732322 - [Monochromatic Themes] The Search bar inside the Sidebar is not visible while using Balanced Themes.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Oana Botisan, Desktop QA]

Attachment: Screenshot 2021-09-23 at 16.44.29.png

Affected versions

• Firefox 94.0a1

Affected platforms

• macOS 10.15

Preconditions

• browser.theme.temporary.monochromatic.enabled = true
• Select one the Grafitti Balanced theme.

Steps to reproduce

1. Go to Application menu -> More tools -> Customize toolbar... and drag the "Show sidebars" button on the Toolbar.
2. Open the Sidebar and make sure you are on the History tab.
3. Observe the Search bar.

Expected result

• The Search bar has a proper outline.

Actual result

• The Search bar is almost invisible.

Regression range

• Not a regression.

Additional notes

• All the Balanced themes are effected except Elemental and Cheers.

Comment 1

[Harry Twyford]

This is a result of us forcing white background colors on a theme that our luminance detectors make a brighttext theme.. I suspect this will have a similar solution to 1732430, where we will need to force light system colors.

Comment 2

[Harry Twyford]

Attachment: Bug 1732322 - Part 1 - Enable color-scheme CSS property in chrome sheets. r?emilio!

Comment 3

[Harry Twyford]

Attachment: Bug 1732322 - Part 2 - Use color-scheme property in sidebar to use the correct system widgets. r?dao!

This patch will also resolve bug 1732291, since we will use the correct light or dark value of -moz-mac-source-list-selection.

Depends on D127300

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ed1ab16dd2f
Part 1 - Enable color-scheme CSS property in chrome sheets. r=emilio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0ed1ab16dd2f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/425d7064b9e2
Part 2 - Use color-scheme property in sidebar to use the correct system widgets. r=dao

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/425d7064b9e2

Comment 8

[Harry Twyford]

Comment on attachment 9243984 [details]
Bug 1732322 - Part 2 - Use color-scheme property in sidebar to use the correct system widgets. r?dao!

Beta/Release Uplift Approval Request

• User impact if declined: Users with the new themes introduced in 94 will see elements with poor contrast in the sidebar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: First part of patch, but I think that landed in 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only patch, scoped only to the sidebar.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9243984 [details]
Bug 1732322 - Part 2 - Use color-scheme property in sidebar to use the correct system widgets. r?dao!

Approved for 94.0b2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f90b0c1d6d2

Comment 11

[Oana Botisan, Desktop QA]

Verified the fix using Firefox 94.0b2 and Firefox 95.0a1 on macOS 10.15. The issue is not reproducing anymore.