1733968 - Make color-scheme: light/dark work on Linux (draw mismatched widgets using the non-native theme)

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Harry Twyford]

Bug 1732322 updated the sidebar to use color-scheme: light/dark to use the respective light/dark system widgets in the sidebar. However, color-scheme doesn't swap widgets out on Linux due to performance concerns. We should use custom styling for the search box on Linux. This is a follow-up on this review comment.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Alternatively we could use non-native themed controls there. Perhaps we can do that magically, not sure how easy to do that'd be, or alternatively with an internal CSS property.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1733968 - Teach Linux to draw mismatched widgets using the non-native theme. r=mstange!

This will make sure we can draw light textboxes with dark gtk themes and
so on.

I've kept the non-native-theme.enabled check, but perhaps we should
start removing that pref...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc9028cb90d7
Teach Linux to draw mismatched widgets using the non-native theme. r=mstange

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cc9028cb90d7

Comment 6

[Harry Twyford]

ni?emilio to request uplift. I would do it, but Emilio is better equipped to explain what's happening in this patch.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9244531 [details]
Bug 1733968 - Teach Linux to draw mismatched widgets using the non-native theme. r=mstange!

Beta/Release Uplift Approval Request

• User impact if declined: We won't be able to honor color-scheme changes in the browser UI, causing issues like bug 1734569.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: bug 1734569 was filed by QA.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We draw light widgets with the non-native theme so as to be able to honor the color-scheme. We were already drawing non-native widgets in some cases (mainly scrollbars), so the patch is reasonably straight-forward.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244531 [details]
Bug 1733968 - Teach Linux to draw mismatched widgets using the non-native theme. r=mstange!

Approved for 94.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/191839720ffe

Comment 10

[Oana Botisan, Desktop QA]

While using Cheers Balanced the search bar is white and it should be dark. Tested this on Ubuntu 18.04 x64 using Firefox 94.0b5.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

It is dark on Nightly, right? Will look into it.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Ouch, yeah, we need bug 1734115, bug 1734723, and bug 1735077 in beta... will request uplifts.

Comment 13

[Oana Botisan, Desktop QA]

On Nightly it's fine. The problem is reproducing only on beta.

Comment 14

[Oana Botisan, Desktop QA]

Verified the fix on Firefox 94.0b6 both using macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing anymore.