1733052 - Revise the popup state if there is valid transient user activation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

This is a temporary solution to make the popup blocker could support new user activation model. For long term, we still need to clean up the popup state bit and remove the old user interaction stuff from popup blocker.

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1733052 - Part 2: Revise popup abuse level if there is a valid transient user activation;

This is a temprorary solution to make popup block could work with new user
activation model (timer base). I think this should cover most of async case for
window.open(). For long term, we still need to clean up the popup state which
is tracked by bug 1656444.

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1733052 - Part 1: Have a consistent popup control state setup when handling a event that is not in allowed list;

Currently the state could be openAbused or openBlocked, the reason for the difference
is for bug 918780 where we would like to fix a issue of opening input dialog might
trigger popup blocker if allowed list is empty. But after bug 1678389, opening input
dialog now checks the transient user activation instead, we don't need this difference
anymore.

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72f5516ee5a059c1ac61258c95ac021610831997

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2852026ef9f
Part 1: Have a consistent popup control state setup when handling a event that is not in allowed list; r=smaug
https://hg.mozilla.org/integration/autoland/rev/d5ec74c1e5ea
Part 2: Revise popup abuse level if there is a valid transient user activation; r=smaug

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a2852026ef9f
https://hg.mozilla.org/mozilla-central/rev/d5ec74c1e5ea