Closed Bug 1734655 Opened 3 years ago Closed 3 years ago

bookmarks folder list in Add bookmark/Edit bookmark panel is white on white/not readable with dark theme

Categories

(Firefox :: Theme, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1734367

People

(Reporter: aryx, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Firefox latest Nightly (95.0a1) on Windows 8.1 (reproduced by me) and 10 (initially reported by code sheriff Andreea)
Patch got uplifted to 94 beta but no beta has been built with it yet.

Since bug 1732430 landed, expanding the folder dropdown in the add/edit bookmark dialog show the folder list has white text on white background.

Flags: needinfo?(htwyford)

Fixed by backout for 94.0b3. We can uplift the proper fix for this alongside bug 1732430 when it's ready to re-land.
https://hg.mozilla.org/releases/mozilla-beta/rev/3d93aa395045

Attached image Screen Shot 2021-10-07 at 2.17.34 PM.png (obsolete) —

I'm seeing a similar issue on Mac. In the Abstract Balanced theme, where we have a brighttext toolbar but darktext panels, the edit bookmark menupopup is black-on-black. We set color-scheme: light on the panel in that theme. Presumably we're getting the correct black text from color-scheme: light but we're not getting the light mode menupopup widget.

Emilio, do you know what's going on here?

Flags: needinfo?(htwyford) → needinfo?(emilio)

Sorry, wrong screenshot...

Attachment #9244851 - Attachment is obsolete: true

The Windows bug is fixed on autoland via bug 1734367. I filed bug 1734716 for the macOS issue described in comment 3.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(emilio)
Resolution: --- → DUPLICATE

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

The Windows bug is fixed on autoland via bug 1734367. I filed bug 1734716 for the macOS issue described in comment 3.

*** This bug has been marked as a duplicate of bug 1734367 ***

Am I understanding correctly that given bug 1734367 comment 8, we're mainly waiting on uplifting the fix for bug 1734716 before bug 1732430 can re-land on Beta?

Flags: needinfo?(emilio)

I intentionally started landing the dark mode fixes post-freeze. The thing I'm not sure about is whether the monocromatic theme stuff depends on any of them, as we might want that on 94. I think the above is accurate on windows (as on 94 windows only draws light form controls), but we might want bug 1733968 for Linux...

Flags: needinfo?(emilio) → needinfo?(htwyford)

The only high-priority monochromatic theme bug here is bug 1732430, which is this bug's regressor. As I understand it, fixing it caused different issues on all platforms:

  • Mac had bug 1735116, where menupopups were not legible.
  • Linux had bug 1733968, where the sidebar search box used the wrong colours
  • Windows is where I'm less sure. 94 on Windows does not support color-scheme: dark, meaning we show white inputs in Dark themes (bug 1735116). Product thinks that's a P3, so it doesn't need to be uplifted. Bug 1734367 comment 8 suggests that menupopups are legible, although they're light in dark themes. We didn't support dark menupopups before, so that isn't a regression.

Does that capture it all? If so, it sounds like we can reland bug 1732430 in Beta after uplifting the Mac issue in bug 1735116 (already requested) and the Linux issue in bug 1733968. Is that accurate?

Flags: needinfo?(htwyford) → needinfo?(emilio)

I think that's right, but might be worth asking QA to do a sanity-check once those are uplifted to ensure we haven't missed anything.

Flags: needinfo?(emilio)

QA, once bug 1735116 and bug 1733968 are uplifted, could you please check contrast in the Edit Bookmark panel on all platforms in Beta? You only need to check Abstract Balanced and Cheers Balanced. We want to check that:

  • The text in the folder-selection popup has good contrast on all platforms
  • On Mac and Linux, the folder-selection popup uses dark colors in Cheers Balanced and light colors in Abstract Balanced. On Windows, we expect to use light colors in both themes.
  • On Mac and Linux, the input fields use dark colors in Cheers Balanced and light colors in Abstract Balanced. On Windows, we expect to use light colors in both themes.

On Linux and Mac, please also check that the sidebar search box is dark in Cheers Balanced and light in Abstract Balanced. It's expected to be light in both themes on Windows.

Flags: qe-verify?
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: