1739888 - The layout of the "Settings for Clearing History" dialog is broken in the Japanese environment of Ubuntu.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[EarlgreyTea]

Attachment: Settings for Clearing History.jpg

User-Agent:
Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to Reproduce:

1. Install Firefox 94.0 (ja) in Ubutu Japanese environment.
2. Start Firefox.
3. Open about:preferences#privacy and go "履歴" section.
4. Select "記憶させる履歴を詳細設定する" (Use custom settings for history).
5. Check "Firefox の終了時に履歴を消去する" (Clear history when Firefox closes).
6. Push "設定...." (Settings...).

Actual Results:

Text and buttons at the bottom right are cut off.

Expected Results:

All text and buttons should not be cut off.

Additional Infomation

flex="1" is not set in <vbox> element of "Offline webstite data".
https://searchfox.org/mozilla-central/source/browser/components/preferences/dialogs/sanitize.xhtml#66
It seems that this is causing the layout to be corrupted.

Comment 1

[Simona Badau, Desktop QA]

Setting this to NEW, as I can reproduce it on Ubuntu 20.04 x64 on the ja builds of Nightly 96.0a1, Firefox 95 beta 4, Firefox 94.0.1, and Firefox 91.3.0 esr.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This is very similar to bug 1705370. @gijs, this is now our second bug that was filed related to spacing within the Clear Recent History subdialog. Could this be a result of bug 1721466 or bug 1720262? I looked through the diffs for those changes and they don't look like they would have caused this but the timing is very suspicious.

Comment 3

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)

This is very similar to bug 1705370. @gijs, this is now our second bug that was filed related to spacing within the Clear Recent History subdialog. Could this be a result of bug 1721466 or bug 1720262? I looked through the diffs for those changes and they don't look like they would have caused this but the timing is very suspicious.

comment #1 indicates ESR is affected, and bug 1712750 and the two bugs you highlighted all only landed in 92 and weren't uplifted. bug 1705370 also predates them.

This previously regressed when we moved away from XUL grid, x-ref bug 1526379 - but that patch has flex="1" on that container for the sanitize.[xhtml] in browser/base, but not for the preferences one, so off-hand I'd think comment 0 is just correct and it needs a flex=1, maybe, so that the vbox doesn't cause the container to get bigger, instead wrapping the checkbox's label (which happens in the other screenshot in bug 1526379) - does that look right to you?

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1739888 - allow offline website data checkbox label in prefs' sanitize (clear recent history) dialog to wrap, r?#preferences-reviewers

Comment 5

[:Gijs (he/him)]

I tested this and adding flex=1 seems like the right fix, so I'll put up a patch with that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b5c5d6834a1
allow offline website data checkbox label in prefs' sanitize (clear recent history) dialog to wrap, r=preferences-reviewers,jaws

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9b5c5d6834a1

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[:Gijs (he/him)]

Comment on attachment 9253908 [details]
Bug 1739888 - allow offline website data checkbox label in prefs' sanitize (clear recent history) dialog to wrap, r?#preferences-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Broken dialog
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Single attribute change in markup
• String changes made/needed: No

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bdd631aed88a

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9253908 [details]
Bug 1739888 - allow offline website data checkbox label in prefs' sanitize (clear recent history) dialog to wrap, r?#preferences-reviewers

Approved for 96.0b5

Comment 12

[Monica Chiorean]

Reproduced the issue on Ubuntu 20.4x64 using 94.0 JA build.
Verified as fixed on Ubuntu 20.4x64 using 96.0b5(20211214203716) and 97.0a1(20211214213409). Display is also correct on Win10x64 using 97.0a1(20211214213409).

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9253908 [details]
Bug 1739888 - allow offline website data checkbox label in prefs' sanitize (clear recent history) dialog to wrap, r?#preferences-reviewers

Trivial fix, let's get this on 91.5esr also.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/a9b1378e1987

Comment 15

[Monica Chiorean]

Verified as fixed on Ubuntu 20.4 using "JA" build 91.5.0esr (20220105212146).