1744144 - Unable to configure CardDAV because new CardDAV Address book dialog doesn't resize after fetching available address books

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P2)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-12-02 14-16-27.png

STR

• New Address Book tab
• Select Add CarDav Address Book
• Fill up the fields and click continue

If multiple address books are available and listed, the dialog doesn't resize properly to accommodate the new content, resulting in the buttons being pushed outside the viewport area.

Comment 1

[Thomas D. (:thomas8)]

Good find!

Clarify summary - it's true that Thunderbird does almost everything, but we're not into cars yet, so it's CardDAV, not CarDav... (also in comment 0). ;-)

Comment 2

[Lukas.Wringer]

Hi, the bug is still present in Beta (101 B4) and Daily (102 A1). Having multiple address books results in not being able to select them and even worse the "continue" Button can not be clicked which results in not being able to configure CardDAV address books at all.

Comment 3

[Thomas D. (:thomas8)]

(In reply to Lukas.Wringer from comment #2)

Hi, the bug is still present in Beta (101 B4) and Daily (102 A1). Having multiple address books results in not being able to select them and even worse the "continue" Button can not be clicked which results in not being able to configure CardDAV address books at all.

I don't have a testcase for this and don't know how to create one, but assuming that Lukas comment 2 is accurate, "not being able to select them" and "not being able to configure CardDAV ABs at all" sound like pretty serious limitations.

Henry, Richard, any easy fixes to make this scalable?

Comment 4

[Thomas D. (:thomas8)]

If this really prevents adding CardDAV ABs from a slightly longer list (> 2 ABs, see screenshot above), enterprise with multiple CardDAV ABs would be much affected by this.

Comment 5

[Richard Marti (:Paenglab)]

I can't test it too. Maybe there is a possibility to use a resizeDialog() to make the dialog grow.

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

We could do sizeToContent as well. However since the list can in principle be arbitrarily long, we might want to make the list have a max-height and be scrollable as well. Based on my reviews for bug 1703164, it can get messy trying to resize with a xul layout, so we might just have to make the body scrollable instead.

Also, this might be a regression from https://hg.mozilla.org/comm-central/rev/a4c122858ebe9bb672b411e093e6342a53a1243a in bug 1703164 because it set a fixed height on the dialog.

Comment 7

[Magnus Melin [:mkmelin]]

That likely didn't make it better, though probably this dialog never handled very long lists well.
The setup really shouldn't be inside a dialog but inside a (the unified setup) tab. We can put some duct-tape on top, but inside a small dialog this will never play out nicely with larger lists.

Comment 8

[Lukas.Wringer]

I think the continue/cancel buttons should maybe be moved to the top (for example like on a typical GTK dialog) and the list should indeed be scrollable. With three elements a faint line of the buttons is still visible, with 4 or more I can neither toggle the checkboxes after the fourth one nor click the continue or cancel button, so I can only use the "x" to abort the setup.

Btw. the CardDav button in mail account creation windows still triggers the old ui but that is probably another bug...

Comment 9

[Geoff Lankow (:darktrojan)]

I am looking a bit more closely at these dialogs this week, I'll see what can be done.

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1744144 - Make the CardDAV dialog expand when more space is needed. r=aleca

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5f75221bb810
Make the CardDAV dialog expand when more space is needed. r=aleca

Comment 12

[Thomas D. (:thomas8)]

(In reply to Pulsebot from comment #11)

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5f75221bb810
Make the CardDAV dialog expand when more space is needed. r=aleca

Geoff, can you summarize the new behaviour? Can it handle arbitrary numbers of CardDav ABs now, say 50+?

Comment 13

[Geoff Lankow (:darktrojan)]

The dialog gets bigger. If it's still not big enough the list scrolls.

Comment 14

[Geoff Lankow (:darktrojan)]

Comment on attachment 9281344 [details]
Bug 1744144 - Make the CardDAV dialog expand when more space is needed. r=aleca

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: dialog is truncated, can't get to the buttons
Testing completed (on c-c, etc.): landed yesterday
Risk to taking this patch (and alternatives if risky):

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9281344 [details]
Bug 1744144 - Make the CardDAV dialog expand when more space is needed. r=aleca

[Triage Comment]
Approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/75c48266620a