1748826 - 0.43 - 0.22% installer size / installer size + 2 more (OSX) regression on Tue January 4 2022

Status: RESOLVED WONTFIX

(Core :: Audio/Video: cubeb, defect)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a build_metrics performance regression from push 0046175b2c53ae7458385ec4ad1a454b5b145017. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.43%	installer size	osx-aarch64-shippable	aarch64 nightly	80,362,784.67 -> 80,710,489.50
0.43%	installer size	osx-shippable	nightly	83,159,202.00 -> 83,513,942.00
0.35%	installer size	osx-shippable	instrumented	116,883,317.56 -> 117,290,835.17
0.22%	installer size	osx-cross		80,174,652.33 -> 80,348,936.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Paul Adenot (:padenot)]

This is a transient change, while a couple of issues are sorted out on Windows and Linux.

The bugs in which this will be fixed are bug 1726279 (for the fix) and bug 1697845 (for the removal).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1748160

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Are those removals targeting 97 still (merging to Beta on Monday) or will they be riding a later train?

Comment 4

[Matthew Gregan [:kinetik]]

Enabling for Windows/Linux and the code removals will happen early in 98.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1748160

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Do we have more options for addressing this for Fx97 given the upcoming disabling in bug 1750938?

Comment 7

[Matthew Gregan [:kinetik]]

Sure thing, I can update the backout patch in bug 1750938 to also back out bug 1748160.

Comment 8

[Greg Mierzwinski [:sparky]]

Hi :kinetik, I'm resolving this bug as a WONTFIX based on the conservation 3 years ago. Feel free to change it if needed.

Comment 9

[Greg Mierzwinski [:sparky]]

(In reply to Greg Mierzwinski [:sparky] from comment #8)

Hi :kinetik, I'm resolving this bug as a WONTFIX based on the conservation 3 years ago. Feel free to change it if needed.