1726279 - Enable audioIPC IPC rework for Windows and Linux

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Description

[Matthew Gregan [:kinetik]]

After landing bug 1726275 and an initial period of testing for macOS, enable for Windows and Linux.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: WIP: Bug 1726279 - Enable AudioIPC rework for Windows and Linux.

Comment 2

[Matthew Gregan [:kinetik]]

This looks green on Try, so should be good to land soon: https://treeherder.mozilla.org/jobs?repo=try&revision=3026ba7d4a76cc23b5780272ac2d430c6726e2aa

Comment 3

[Matthew Gregan [:kinetik]]

Aiming for Firefox 98 to land this.

TODO:

• Rename audioipc2 crates back to audioipc
• Merge macos branch to master
• Refresh WIP patch to include above

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: Bug 1726279 - Enable AudioIPC rework for Windows and Linux by default. r?#cubeb-reviewers

Comment 5

[Matthew Gregan [:kinetik]]

The code removal will be done in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1697845. This bug will track preffing on v2 for Windows/Linux by default once bug 1748160 lands.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0e816460df3
Enable AudioIPC rework for Windows and Linux by default.  r=cubeb-reviewers,padenot

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46d88977f644
Backed out changeset e0e816460df3 for causing dt failures on browser_devtools-presets.js

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_devtools-interrupted.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/46d88977f64466c2eac059fa994ea4c16704f5fd

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=QE_fs7t7RYmz80CyK7y8xw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e0e816460df3dafbdf076e72bb7c4125cd0b03c7

Failure log(s): https://treeherder.mozilla.org/logviewer?job_id=363761394&repo=autoland&lineNumber=5177

Failure line(s): PROCESS-CRASH | devtools/client/performance-new/test/browser/browser_devtools-interrupted.js | application crashed [@ audioipc2::ipccore::EventLoopHandle::add_connection]

Comment 9

[Matthew Gregan [:kinetik]]

Attachment: GitHub Pull Request

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87c9ad37b4f7
Enable AudioIPC rework for Windows and Linux by default.  r=cubeb-reviewers,padenot

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/87c9ad37b4f7

Comment 12

[Matthew Gregan [:kinetik]]

Bug 1750810 will revert this change for Linux in Nightly 98 until the existing issues are resolved. Windows will remain enabled as we've had no reports of issues and there are zero Windows crashes showing up on crash-stats.