1750693 - Use pathlib in the "python/mozversioncontrol" module

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task, P2)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

Replace string paths with pathlib objects in the mozversioncontrol module.
Note: to ensure the scope of this bug doesn't explode, don't yet refactor any objects that are included in the context object provided to Mach commands - ensure that it keeps the same API for now.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1750693 - Update tests in mozversioncontrol to be compatible with Windows r?#build

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1750693 - Update string paths to Pathlib objects in Mozversioncontrol module r?#build

Depends on D136209

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1750693 - Minimum changes necessary in mozversioncontrol/test to facilitate Pathlib migration r?#build

The py.path allowed adding arbitrary fields to it, while a pathlib.Path
does not. To replicate the behavior with as few changes as possible, I
made a test fixture wrapper class (RepoTestFixture) to add the same
arbitrary fields to, while now containing a Pathlib path instead.

Also added some utility functions to make the running of tests a
bit cleaner ('execute_next_step' and 'execute_multiple_steps')

Depends on D136301

Comment 4

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1750693 - Removed `update_git_repo` function since it is unused r?#build

Depends on D136301

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/257e51d38bb2
Update tests in mozversioncontrol to be compatible with Windows r=firefox-build-system-reviewers,mhentges

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/257e51d38bb2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bab903b927b
Removed `update_git_repo` function since it is unused r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/cde3b4e115e9
Update string paths to Pathlib objects in Mozversioncontrol module r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/a53cb68d7632
Minimum changes necessary in mozversioncontrol/test to facilitate Pathlib migration r=firefox-build-system-reviewers,mhentges

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6bab903b927b
https://hg.mozilla.org/mozilla-central/rev/cde3b4e115e9
https://hg.mozilla.org/mozilla-central/rev/a53cb68d7632