Closed
Bug 1750693
Opened 2 years ago
Closed 2 years ago
Use pathlib in the "python/mozversioncontrol" module
Categories
(Firefox Build System :: Mach Core, task, P2)
Firefox Build System
Mach Core
Tracking
(firefox98 fixed)
RESOLVED
FIXED
98 Branch
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: ahochheiden, Assigned: ahochheiden)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
Replace string paths with pathlib
objects in the mozversioncontrol
module.
Note: to ensure the scope of this bug doesn't explode, don't yet refactor any objects that are included in the context object provided to Mach commands - ensure that it keeps the same API for now.
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → ahochheiden
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D136209
Assignee | ||
Comment 3•2 years ago
|
||
The py.path allowed adding arbitrary fields to it, while a pathlib.Path
does not. To replicate the behavior with as few changes as possible, I
made a test fixture wrapper class (RepoTestFixture) to add the same
arbitrary fields to, while now containing a Pathlib path instead.
Also added some utility functions to make the running of tests a
bit cleaner ('execute_next_step' and 'execute_multiple_steps')
Depends on D136301
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D136301
Updated•2 years ago
|
Attachment #9259635 -
Attachment description: Bug 1750693 - Update string path to Pathlib objects in Mozversioncontrol module r?#build → Bug 1750693 - Update string paths to Pathlib objects in Mozversioncontrol module r?#build
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/257e51d38bb2 Update tests in mozversioncontrol to be compatible with Windows r=firefox-build-system-reviewers,mhentges
Comment 6•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6bab903b927b Removed `update_git_repo` function since it is unused r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/cde3b4e115e9 Update string paths to Pathlib objects in Mozversioncontrol module r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/a53cb68d7632 Minimum changes necessary in mozversioncontrol/test to facilitate Pathlib migration r=firefox-build-system-reviewers,mhentges
Comment 8•2 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•