Use pathlib in the "python/mozboot" module
Categories
(Firefox Build System :: Bootstrap Configuration, task, P2)
Tracking
(firefox98 fixed)
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: ahochheiden, Assigned: ahochheiden)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Replace string paths with pathlib
objects in the mozboot
module.
Note: to ensure the scope of this bug doesn't explode, don't yet refactor any objects that are included in the context object provided to Mach commands - ensure that it keeps the same API for now.
Assignee | ||
Comment 1•2 years ago
|
||
Still a work in progress.
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D133164
Assignee | ||
Comment 3•2 years ago
|
||
What this function does can easily be a one-liner now that we're using
Pathlib, so both calls to it have been replaced by said one-liner.
Depends on D135262
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D135263
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D135264
Assignee | ||
Comment 6•2 years ago
|
||
Added usage during configure_git
for cinnabar directory location
instructions for adding to PATH.
Depends on D135265
Assignee | ||
Comment 7•2 years ago
|
||
Depends on D135266
Updated•2 years ago
|
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c17501dd047 Remove 'emulator_path` creation from get_paths function in android.py since it is not used. r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/4aec4364abea Update string paths to Pathlib objects in Mozboot module r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/95708173a6db Remove `ensure_dir` function from android.py r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/1a1e492795ec Remove 'os_arch' parameter from `ensure_android_sdk_and_ndk` since it was not used. r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/bfd8fca892df Remove `no_interactive` parameter from `run_prewarm_avd` in android.py since it was not used. r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/0ad58353702a Move `win_to_msys_path` helper function outside of `Bootstrapper` class to `mach/util.py` so that it can be used elsewhere. r=firefox-build-system-reviewers,mhentges https://hg.mozilla.org/integration/autoland/rev/e2fef3d56ce5 Remove `requests` module import, as it's already in-scope by the time of bootstrap (since to Bug 1647792) r=firefox-build-system-reviewers,mhentges
Comment 9•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8c17501dd047
https://hg.mozilla.org/mozilla-central/rev/4aec4364abea
https://hg.mozilla.org/mozilla-central/rev/95708173a6db
https://hg.mozilla.org/mozilla-central/rev/1a1e492795ec
https://hg.mozilla.org/mozilla-central/rev/bfd8fca892df
https://hg.mozilla.org/mozilla-central/rev/0ad58353702a
https://hg.mozilla.org/mozilla-central/rev/e2fef3d56ce5
Updated•2 years ago
|
Updated•2 years ago
|
Description
•