1744884 - Use pathlib in the "python/mozboot" module

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, task, P2)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

Replace string paths with pathlib objects in the mozboot module.
Note: to ensure the scope of this bug doesn't explode, don't yet refactor any objects that are included in the context object provided to Mach commands - ensure that it keeps the same API for now.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Update string paths to Pathlib objects in Mozboot module r?#build

Still a work in progress.

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Remove 'emulator_path` creation from get_paths function in android.py since it is not used. r?#build

Depends on D133164

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Remove `ensure_dir` function from android.py r?#build

What this function does can easily be a one-liner now that we're using
Pathlib, so both calls to it have been replaced by said one-liner.

Depends on D135262

Comment 4

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Remove 'os_arch' parameter from `ensure_android_sdk_and_ndk` since it was not used. r?#build

Depends on D135263

Comment 5

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Remove `no_interactive` parameter from `run_prewarm_avd` in android.py since it was not used. r?#build

Depends on D135264

Comment 6

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Move `win_to_msys_path` helper function outside of `Bootstrapper` class to `mach/util.py` so that it can be used elsewhere. r?#build

Added usage during configure_git for cinnabar directory location
instructions for adding to PATH.

Depends on D135265

Comment 7

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1744884 - Remove `requests` module import, as it's already in-scope by the time of bootstrap (since to Bug 1647792) r?#build

Depends on D135266

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c17501dd047
Remove 'emulator_path` creation from get_paths function in android.py since it is not used. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/4aec4364abea
Update string paths to Pathlib objects in Mozboot module r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/95708173a6db
Remove `ensure_dir` function from android.py r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/1a1e492795ec
Remove 'os_arch' parameter from `ensure_android_sdk_and_ndk` since it was not used. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/bfd8fca892df
Remove `no_interactive` parameter from `run_prewarm_avd` in android.py since it was not used. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/0ad58353702a
Move `win_to_msys_path` helper function outside of `Bootstrapper` class to `mach/util.py` so that it can be used elsewhere. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/e2fef3d56ce5
Remove `requests` module import, as it's already in-scope by the time of bootstrap (since to Bug 1647792) r=firefox-build-system-reviewers,mhentges

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8c17501dd047
https://hg.mozilla.org/mozilla-central/rev/4aec4364abea
https://hg.mozilla.org/mozilla-central/rev/95708173a6db
https://hg.mozilla.org/mozilla-central/rev/1a1e492795ec
https://hg.mozilla.org/mozilla-central/rev/bfd8fca892df
https://hg.mozilla.org/mozilla-central/rev/0ad58353702a
https://hg.mozilla.org/mozilla-central/rev/e2fef3d56ce5