1757341 - Selected date on calendar tab minimonth and views are not updated at midnight

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

+++ This bug was initially created as a clone of Bug #1648718 +++

doMidnightUpdate calls getMinimonth().refreshDisplay() which should move the selected day forward at midnight, if the current day was selected. Likewise, the calendar views should update the selected day, but they do not.

Bug 1648718 partially fixed the minimonth, but didn't actually update the selection.

Comment 5

[stevenfalco]

I noticed that if I click the button to move one month forward, then click to move one month backward, the correct "Today" is highlighted. So at least as a work-around that is less annoying than having to restart thunderbird.

Comment 6

[tobias.thommes]

(In reply to stevenfalco from comment #5)

I noticed that if I click the button to move one month forward, then click to move one month backward, the correct "Today" is highlighted. So at least as a work-around that is less annoying than having to restart thunderbird.

Yes, it also works when clicking "Today" after moving one or more months forward or backward. But still the bug remains.

Comment 7

[Arthur K. (he/him)]

For the most part, I haven't seen this issue in a long time. One thing I have seen is that closer to a later evening time (CST in my case), I sometimes see the calendar has moved to the next day. I thought it might have been my Windows Date & Time settings but they were set correctly. It's very random.

Comment 12

[tobias.thommes]

For me, the bug seems to be fixed now (@ 108.0b1)!
The current day correctly increments at midnight now. :-)

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to tobias.thommes from comment #12)

For me, the bug seems to be fixed now (@ 108.0b1)!
The current day correctly increments at midnight now. :-)

Geoff, The blocking bugs are all fixed. Anything left to do?

Comment 14

[Geoff Lankow (:darktrojan)]

The selected day still isn't updated. So no. The "today" day is, but the selected day isn't.

Comment 15

[Geoff Lankow (:darktrojan)]

I mean yes, there's things left to do. Answering the question as asked helps.

Comment 16

[tobias.thommes]

Why should the selected day be updated? I would not expect that...
The selected day should at most be updated if it equals the "today" day, otherwise not.
But this would then rather be a feature request than a bug, or not?

Comment 17

[Geoff Lankow (:darktrojan)]

The selected day should at most be updated if it equals the "today" day, otherwise not.

That's what I said in comment 0.

Comment 21

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1757341 - Overhaul doMidnightUpdate so that the calendar tab gets updated at midnight. r=#thunderbird-reviewers

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1afd2d616aaf
Overhaul doMidnightUpdate so that the calendar tab gets updated at midnight. r=tobyp,mkmelin

Comment 23

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed with 133.0b3(20241107210012) using Windows 11, macOS 14, and Ubuntu 22.

Comment 24

[Geoff Lankow (:darktrojan)]

Comment on attachment 9431535 [details]
Bug 1757341 - Overhaul doMidnightUpdate so that the calendar tab gets updated at midnight. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): I'm not really sure, potentially never worked 100%.
User impact if declined: calendar fails to update when the date changes.
Testing completed (on c-c, etc.): landed on central in 133.0a1.
Risk to taking this patch (and alternatives if risky): a little, but this has been on beta for months with no problems I'm aware of.

Comment 26

[Corey Bryant]

Comment on attachment 9431535 [details]
Bug 1757341 - Overhaul doMidnightUpdate so that the calendar tab gets updated at midnight. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 27

[Daniel Darnell [:dandarnell]]

Thunderbird 128.5.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/780650e0d5a0