Closed Bug 1753767 Opened 2 years ago Closed 2 years ago

Eliminate preprocessor %includes from the theme's browser.css and associated stylesheets

Categories

(Firefox :: Theme, task)

task
Points:
5

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting])

Attachments

(1 file)

The long list of includes in this file may warrant a different approach from simply replacing the %include with an @import, if that may regress startup performance. See bug 1659584 for more details.

  • browser/themes/{platform}/browser.css
    • browser/themes/shared/browser.inc.css
      • browser/themes/shared/downloads/indicator.inc.css
      • browser/themes/shared/addons/extension-controlled.inc.css
      • browser/themes/shared/places/places-tooltip.inc.css
    • browser/themes/shared/toolbarbuttons.inc.css
    • browser/themes/shared/toolbarbutton-icons.inc.css
    • browser/themes/shared/menupanel.inc.css
    • browser/themes/shared/urlbar-searchbar.inc.css
    • browser/themes/shared/identity-block/identity-block.inc.css
    • browser/themes/shared/notification-icons.inc.css
    • browser/themes/shared/addon-notification.inc.css
    • browser/themes/shared/urlbarView.inc.css
      • browser/themes/shared/urlbar/dynamicResults.inc.css
    • browser/themes/shared/translation/infobar.inc.css
    • browser/themes/shared/autocomplete.inc.css
    • browser/themes/shared/places/editBookmarkPanel.inc.css
    • browser/themes/shared/sidebar.inc.css
    • browser/themes/shared/tabs.inc.css
    • browser/themes/shared/fullscreen/warning.inc.css
    • browser/themes/shared/ctrlTab.inc.css
    • browser/themes/shared/customizableui/customizeMode.inc.css
    • browser/themes/shared/UITour.inc.css
    • browser/themes/shared/contextmenu.inc.css
Whiteboard: [fidefe-2022-mr1-css-linting]
Attachment #9266394 - Attachment description: WIP: Bug 1753767 - WIP use @import instead of %include-ing stylesheets in browser/themes → WIP: Bug 1753767 - (WIP) use @import instead of %include-ing stylesheets in browser/themes
Blocks: 1758176
Blocks: 1758178
Blocks: 1758179
Blocks: 1758180
Blocks: 1758181
Blocks: 1758182
Blocks: 1758183
Blocks: 1758184
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Attachment #9266394 - Attachment description: WIP: Bug 1753767 - (WIP) use @import instead of %include-ing stylesheets in browser/themes → WIP: Bug 1753767 - use @import instead of %include-ing stylesheets in browser/themes
Attachment #9266394 - Attachment description: WIP: Bug 1753767 - use @import instead of %include-ing stylesheets in browser/themes → Bug 1753767 - use @import instead of %include-ing stylesheets in browser/themes. r?Dao!
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4358621eab8
use @import instead of %include-ing stylesheets in browser/themes. r=dao
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Regressions: 1760175
Regressions: 1768380
Regressions: 1769210
Regressions: 1768376
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: