1769071 - Remove the migration code for cleaning the search param prefs

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Tim Huang[:timhuang]]

Given that we have scheduled the dot release for the Bug1766441. We don't need the cleanup code that was added in Bug 1767440. However, we should keep the UI_VERSION number and only remove the code that cleans up the search param prefs in here. So, we won't mess up with the migration code.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1769071 - Remove the clean up code for the search param prefs in the migration code in the BrowserGlue.jsm r?#anti-tracking-reviewers

The clean up code for the search param prefs is not necessary anymore.
This patch remove the code but doesn't touch the UI Version number so
that we won't mess up with the migration steps in the future.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd20e01cef60
Remove the clean up code for the search param prefs in the migration code in the BrowserGlue.jsm r=anti-tracking-reviewers,bvandersloot

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dd20e01cef60

Comment 4

[Tim Huang[:timhuang]]

Comment on attachment 9276399 [details]
Bug 1769071 - Remove the clean up code for the search param prefs in the migration code in the BrowserGlue.jsm r?#anti-tracking-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Firefox might run unnecessary code during browsing starting up.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The bug removes unnecessary code that we don't need for the migration that we run on browser startups. It doesn't change any behavior and the patch is small. So, the risk is low.
• String changes made/needed: nope
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9276399 [details]
Bug 1769071 - Remove the clean up code for the search param prefs in the migration code in the BrowserGlue.jsm r?#anti-tracking-reviewers

Approved for 101.0b8.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3e9db832b8f5