Closed
Bug 176926
Opened 23 years ago
Closed 23 years ago
document.image.src= fails (rollovers)
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.2final
People
(Reporter: rrkramer, Assigned: bryner)
References
()
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
2.08 KB,
patch
|
hyatt
:
review+
bzbarsky
:
superreview+
brendan
:
approval+
|
Details | Diff | Splinter Review |
The page has a form that contains and image and a button that calls a javascript
function that should replace the image with another.
The function is called, but the image is not replaced. This worked with 20021016
and all the earlier releases I had tried.
|
||
Comment 1•23 years ago
|
||
->DOM HTML
Assignee: rogerl → jst
Component: JavaScript Engine → DOM HTML
QA Contact: pschwartau → stummala
|
||
Comment 2•23 years ago
|
||
regression between linux trunk builds 2002102322 and 2002102508
debug build says:
###!!! ASSERTION: failed to find attribute: 'attr', file nsHTMLAttributes.cpp,
line 1187
marking NEW
|
||
Comment 3•23 years ago
|
||
This is a regression from bug 22820. if the hint is content, the attr is not
mapped; otherwise it is. nsHTMLAttributes can't deal and gets confused.... (we
really need to fix how that's determined!).
Assignee: jst → bryner
|
Assignee | |
Comment 4•23 years ago
|
||
I talked to hyatt about this, and he said that using a framechange hint here is
incorrect since it makes 'src' into a style-mapped attribute. I have an
alternate approach that uses PresShell's ReconstructFramesFor() and seems to fix
the original bug without causing this regression. Patch coming up.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2final
|
|
Assignee | |
Comment 5•23 years ago
|
||
typo in above comment: I meant to say "RecreateFramesFor", not
"ReconstructFramesFor".
|
|
||
Comment 6•23 years ago
|
||
I'd make that
} else if (mDocument) {
// reconstruct frame
}
and not bother with the nodeinfo... right no the only way you get into the else
is if mDocument is non-null or if SetAttr failed (and in the latter case do we
really want to reconstruct?).
sr=bzbarsky with that change.
Comment on attachment 104310 [details] [diff] [review]
patch
Well, I really don't like the idea of RecreateFramesFor in the first place, but
I guess it's better than the altenative.
In the longer term, this would probably be fixed by implementing the CSS3
'content' property. I also have a bug on removing / reducing the uses of the
rule-based hints.
Regarding bz's comment, I'd prefer:
NS_ENSURE_SUCCESS(rv, rv);
if (!mDocument) {
/* current code */
} else {
/* your new code */
}
|
||
Comment 8•23 years ago
|
||
*** Bug 176957 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 9•23 years ago
|
||
Attachment #104310 -
Attachment is obsolete: true
|
|
||
Comment 10•23 years ago
|
||
Comment on attachment 104332 [details] [diff] [review]
address dbaron and bz's comments
sr=bzbarsky
Attachment #104332 -
Flags: superreview+
|
||
Comment 11•23 years ago
|
||
Comment on attachment 104332 [details] [diff] [review]
address dbaron and bz's comments
r=hyatt
Attachment #104332 -
Flags: review+
|
|
||
Comment 12•23 years ago
|
||
*** Bug 177043 has been marked as a duplicate of this bug. ***
|
||
Comment 13•23 years ago
|
||
*** Bug 177096 has been marked as a duplicate of this bug. ***
|
||
Comment 14•23 years ago
|
||
*** Bug 177172 has been marked as a duplicate of this bug. ***
|
||
Updated•23 years ago
|
Summary: document.image.src =' ... fails → document.image.src= fails (rollovers)
|
||
Comment 15•23 years ago
|
||
*** Bug 177304 has been marked as a duplicate of this bug. ***
|
|
||
Comment 16•23 years ago
|
||
*** Bug 177058 has been marked as a duplicate of this bug. ***
|
||
Comment 17•23 years ago
|
||
*** Bug 177375 has been marked as a duplicate of this bug. ***
|
|
||
Comment 18•23 years ago
|
||
*** Bug 177381 has been marked as a duplicate of this bug. ***
|
||
Comment 19•23 years ago
|
||
*** Bug 177042 has been marked as a duplicate of this bug. ***
|
||
Comment 20•23 years ago
|
||
Comment on attachment 104332 [details] [diff] [review]
address dbaron and bz's comments
a=brendan@mozilla.org for 1.2final.
/be
Attachment #104332 -
Flags: approval+
|
|
Assignee | |
Comment 21•23 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 22•23 years ago
|
||
*** Bug 177443 has been marked as a duplicate of this bug. ***
|
|
||
Comment 23•23 years ago
|
||
*** Bug 177444 has been marked as a duplicate of this bug. ***
|
||
Comment 24•23 years ago
|
||
*** Bug 177552 has been marked as a duplicate of this bug. ***
|
||
Comment 25•23 years ago
|
||
*** Bug 177084 has been marked as a duplicate of this bug. ***
|
|
||
Comment 26•23 years ago
|
||
*** Bug 177559 has been marked as a duplicate of this bug. ***
|
||
Comment 27•23 years ago
|
||
*** Bug 86343 has been marked as a duplicate of this bug. ***
|
|
||
Comment 28•23 years ago
|
||
*** Bug 177957 has been marked as a duplicate of this bug. ***
|
||
Comment 29•23 years ago
|
||
*** Bug 178618 has been marked as a duplicate of this bug. ***
|
|
||
Comment 30•23 years ago
|
||
*** Bug 179469 has been marked as a duplicate of this bug. ***
|
||
Comment 31•23 years ago
|
||
*** Bug 179899 has been marked as a duplicate of this bug. ***
|
|
||
Comment 32•23 years ago
|
||
*** Bug 180488 has been marked as a duplicate of this bug. ***
|
|
||
Comment 33•23 years ago
|
||
*** Bug 180820 has been marked as a duplicate of this bug. ***
|
||
Comment 34•22 years ago
|
||
*** Bug 177140 has been marked as a duplicate of this bug. ***
|
||
Comment 35•22 years ago
|
||
works with a recent trunk nightly on win2k. verified.
Status: RESOLVED → VERIFIED
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•