1774455 - In a threaded view sorted by Order Received ascending, Quick Filter resets the sort type to Date

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Bubba]

Steps to reproduce:

User Agent Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1
Build ID 20220520005021

1. Click on Quick Filter Button
2. Enter search term in quick filter

Actual results:

Emails are normally sorted by date descending. When I enter a search term in the quick filter all emails sort by size, with the filter applied. When I cancel the quick filter by clicking on the X, the emails stay sorted by size. This is true no matter what parameter is chosen for "Filter messages by:"

Expected results:

The emails should stay sorted by the sort label chosen before using the quick filter.

Comment 1

[Peter Van der Beken [:peterv]]

I'm seeing something similar on 102.2.2 on MacOS. Steps that reproduce for me:

1. Sort a folder (Inbox in my case) by "Order Received"
2. Open Quick Filter and filter on a word that gives some results
3. The sort order has now changed to "Date".
4. Switch to another folder.
5. Switch back to the first folder.

The quick filter is cleared at this point (because of the switch to another folder), but the sort order is not restored to the original order. I personally also don't expect Quick Filter to change sort order at all.

Bug 1790006 looks similar.

Comment 3

[Bubba]

My current version is 91.11 and Thunderbird is no longer doing this.

Comment 4

[Vincent]

I'm experiencing the same bug, also under macOS with Thunderbird 102.5.0. Thank you Peter for the accurate description.

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Since Quick Filter should now generally be able to keep the sort intact, I am changing the summary of this bug to the special case described in comment 1. Possibly regressed by bug 1266698, at least https://searchfox.org/comm-central/rev/35be0aeea42f282cf0d90d4ce0af7e6ac4c91d8a/mailnews/base/src/nsMsgQuickSearchDBView.cpp#485-489 now seems to cause this.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1774455 - Fix Quick Filter sort in threaded views sorted by Order Received ascending. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5b6c7cf236ea
Fix Quick Filter sort in threaded views sorted by Order Received ascending. r=mkmelin

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9420407 [details]
Bug 1774455 - Fix Quick Filter sort in threaded views sorted by Order Received ascending. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: Sorting by Order Received does not work correctly in threaded Quick Filter views and may produce unwanted side effects (see also duplicates of this bug)
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): fairly low

Comment 10

[Corey Bryant]

Comment on attachment 9420407 [details]
Bug 1774455 - Fix Quick Filter sort in threaded views sorted by Order Received ascending. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/7b521e8d86f6