1774712 - 3.3% displaylist_mutate (OSX) regression on Tue June 7 2022

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push 16090848f1c7e63d3723d9cdf6216b9928cf8428. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
27%	cross_origin_pageload	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	189.45 -> 240.97
10%	tp5o	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	166.44 -> 183.55
3%	displaylist_mutate	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,833.16 -> 1,893.66

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1772094

Comment 2

[Tooru Fujisawa [:arai]]

I don't see the regression for the range, or next stack.
so it should be from some other patch.

"Bug 1772094 - Part 8" vs "parent of Bug 1772094 - Part 3"
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=8563f73c6a197f00452b5e5da2e460942398de76&newProject=try&newRevision=d16945ad0bcb4d7ddc2349a29d1a3476bffb9e93&framework=1&page=1&showOnlyComparable=1

"Bug 1772099 - Part 14" vs "parent of Bug 1772094 - Part 3"
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=8563f73c6a197f00452b5e5da2e460942398de76&newProject=try&newRevision=7154cc5a468ad4b10516ab44d7370e1b720fd1c6&framework=1&page=1&showOnlyComparable=1

I'll look into other patches around that range.

Comment 3

[Tooru Fujisawa [:arai]]

Also no regression for bug 1772101.

"Bug 1772101 - Part 50" vs "parent of Bug 1772094 - Part 3"
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=8563f73c6a197f00452b5e5da2e460942398de76&newProject=try&newRevision=73ae9b65058264c2d8a05c8e9ff28922e38cd6c7&framework=1&page=1&showOnlyComparable=1

Comment 4

[Tooru Fujisawa [:arai]]

it's from the following range
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6348e6918e0def0801676f39dc34f34b4358bf27&tochange=804d4cc1ed3766d5a70a8a914c3721bb23aee816

"Bug 1772960" vs "parent of Bug 1772956 = Bug 1772101 - Part 50"
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=73ae9b65058264c2d8a05c8e9ff28922e38cd6c7&newProject=try&newRevision=b491d7a61685f7be3f08bc755a3f40f76eb4c8e5&framework=1&page=1&showOnlyComparable=1

Comment 5

[Tooru Fujisawa [:arai]]

bug 1670885 is more likely, given it caused another regression in bug 1773984.
I'll check the benchmark.

Comment 6

[Tooru Fujisawa [:arai]]

bug 1670885 part 2 vs part 1
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=ca705f465f1240183503d3d0f6ac8c5b0865b07b&newProject=try&newRevision=81ea6516165b15a9d3b5a8a32bc2ad6b15a8c86d&framework=1&page=1&showOnlyComparable=1

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:gsvelto, since you are the author of the regressor, bug 1670885, could you take a look?
For more information, please visit auto_nag documentation.

Comment 8

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Moving component per the regression window.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1670885

Comment 10

[Gabriele Svelto [:gsvelto]]

I'm fixing the regression in bug 1774458.

Comment 11

[Donal Meehan [:dmeehan]]

Setting 103 and 104 to Fixed, bug 1774458 landed in central and was uplifted to beta.