1777214 - Cannot edit contacts with a least 2 e-mail addresses (when PREF=1 missing)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Andreas]

Steps to reproduce:

I have contacts with at least 2 e-mail addresses which are synced with CardDAV. When I click the "edit" button, nothing happens.
When I edit a contact with one e-mail in Thunderbird and add a second e-mail address, everything works as expected. Adding a second e-mail address in the webmailer and syncing it to Thunderbird makes the edit button stop working.
I can reproduce this behaviour with CardDAV address books hosted by posteo.de and google.com.

Comment 1

[Wayne Mery (:wsmwk)]

Are you using an add-on?

Comment 2

[Andreas]

No, I use the build-in CardDAV function.
I see the same behaviour in troubleshoot mode with deactivated add-ons.

Comment 3

[jodelhodel32]

I have the same problem!
Looking the Error-Console, the following errors are logged when trying to edit these contacts

about:addressbook : Unable to run script because scripts are blocked internally. 30

Uncaught TypeError: defaultEmail is undefined
    getDefaultEmail chrome://messenger/content/addressbook/edit/edit.js:313
    updateEmailHeading chrome://messenger/content/addressbook/edit/edit.js:294
    updateView chrome://messenger/content/addressbook/edit/edit.js:172
    set vCardProperties chrome://messenger/content/addressbook/edit/edit.js:110
    editCurrentContact chrome://messenger/content/addressbook/aboutAddressBook.js:2858
    _onClick chrome://messenger/content/addressbook/aboutAddressBook.js:3180
    handleEvent chrome://messenger/content/addressbook/aboutAddressBook.js:2313

Comment 4

[jodelhodel32]

Found the possible issue, vCard contacts which have multiple email addresses but are not marked with the "pref=1" key in the vcf, cannot be edited by Thunderbird and the error above is thrown

# OK (has "PREF" KEY )
EMAIL;PREF=1;TYPE=home:[e-mail]
EMAIL;TYPE=work:[e-mail]


# ERROR (PREF=1 missing)
EMAIL;TYPE=other:[e-mail]
EMAIL;TYPE=other:[e-mail]

Comment 5

[u695164]

Thanks for the bug report and investigating the issue!
Can confirm this. The default email handling needs to be more defensive. Address Books from other sources e.g. Google might truncate the pref value.

Comment 8

[u695164]

Attachment: Bug 1777214 - Fallback for Address Books with no pref support. r=darktrojan

Comment 9

[Wayne Mery (:wsmwk)]

This is pretty bad? IF so Let's get it uplifted ASAP.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f08f20b2d72d
Fallback for Address Books with no pref support. r=darktrojan

Comment 11

[u695164]

Comment on attachment 9283631 [details]
Bug 1777214 - Fallback for Address Books with no pref support. r=darktrojan

[Approval Request Comment]
User impact if declined: Contacts who have more than one email and are from a different source besides the vCard based Address Books from Thunderbird are not editable by us.
Testing completed (on c-c, etc.): just landed on c-c, test coverage should follow. Manual tested by me on linux64 with CardDAV from google.
Risk to taking this patch (and alternatives if risky): The patch is not platform dependent. Another pair of eyes for this issue would decrease the risk.

Comment 12

[u695164]

(In reply to Wayne Mery (:wsmwk) from comment #9)

This is pretty bad? IF so Let's get it uplifted ASAP.

This is pretty bad. Let's get it up!

Comment 13

[Rob Lemley [:rjl]]

Comment on attachment 9283631 [details]
Bug 1777214 - Fallback for Address Books with no pref support. r=darktrojan

[Approval Request Comment]
Needs to be on beta before 102.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9283631 [details]
Bug 1777214 - Fallback for Address Books with no pref support. r=darktrojan

[Triage Comment]
Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 103.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f70e72e734e6

Comment 16

[Wayne Mery (:wsmwk)]

optimistically approving for TB102.0.1 - assuming it will pass beta over the next several days

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/04ca9ee0ba45

Comment 19

[Rob Lemley [:rjl]]

Comment on attachment 9283631 [details]
Bug 1777214 - Fallback for Address Books with no pref support. r=darktrojan

[Triage Comment]