Closed Bug 17801 Opened 25 years ago Closed 24 years ago

[FEATURE] navigation across folders/groups

Categories

(MailNews Core :: Backend, defect, P2)

Product:
MailNews Core
Component:
Backend
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: laurel, Assigned: sspitzer)

References

Details

(Whiteboard: [dogfood-] 3 days)

Attachments

(3 files)

a first cut at a fix.
7.21 KB, patch
Details | Diff | Splinter Review
the latest patch
6.76 KB, patch
Details | Diff | Splinter Review
patch to make it go across servers.
3.02 KB, patch
Details | Diff | Splinter Review 
This bug is to track implementation of navigation commands going across folders
or newsgroups.

Crossing folders applies to various commands:
  a.  next unread message
  b.  next unread thread
  c.  next unread folder
  d.  next unread group
QA Contact: lchiang → fenella
When it's time to verify, please provide any (new) rules which may apply because
of multiple accounts.
Blocks: 10791
Status: NEW → ASSIGNED
Target Milestone: M16
Whiteboard: 3 days
Syncing priority with marketing.  Moving to P2 to connote "In" for beta2.
Priority: P3 → P2
moving to M17
Target Milestone: M16 → M17
[FEATURE] bugs past M16 are OUT for this release.  Marking M20.  If you disagree 
with this action, please help me explain it to the PDT.
Target Milestone: M17 → M20
I really use this feature quite a bit.  I think that people who filter incoming
messages to other folders without doing any action to mark them read first would
care more about this navigational feature.

I rely on the Next|Unread across folders to tell me if there really is something
new which was filtered, particularly if it's been filtered to a subfolder in a
currently collapsed hierarchy... I know we have a current bug #19254 to have the
new flag populate up to parent folder in this case, but I have a basic lack of
confidence in our ability to make sure this works all the time.  I know 4.x has
always had some cases where you wouldn't know there's a newly filtered message
in a collapsed hierarchy unless you either looked there specifically or used
navigation across folders.
Keywords: dogfood
[dogfood-] This feature is cut for Seamonkey :-(
Whiteboard: 3 days → [dogfood-] 3 days
Can someone mark it Resolved/Won't Fixed? Or should we wait?
p.s. I am not sure if you want QA to do it.
don't worry fenella - this is marked target milestone M20 which is not Netscape 
6.0 release
Moving target milestone to "future" to be reviewed at a later time
Target Milestone: M20 → Future
*** Bug 56116 has been marked as a duplicate of this bug. ***
I did some hacking on this last night.  taking from putterman.
Assignee: putterman → sspitzer
Status: ASSIGNED → NEW
nominating for mail3.  This is a highly requested feature.
Keywords: mail3
Seth, for parts of this code with which it makes sense to do so, it may be worth 
putting it in a general place rather than a mail/news-specific place. Similar 
navigation applies to Navigator (bug 59118), and possibly to Chatzilla as well.

I don't think this blocks 59118.

the features are similar in nature, but vastly different in implementations.

removing dependency.

accepting bug.
No longer blocks: 59118
Status: NEW → ASSIGNED
while waiting for the 11/4 builds, I came up with a fix.

known problems with my fix.

1) sometimes after switching folders, the selected message doesn't get loaded.
(should be easy to fix)
2) will not go across accounts.  if you are reading mail on an imap server, it
will find all the unread on that server, but not across to the next server.
(again, should be easy to fix.)

3) the confirm that pops up "Advance to next unread message in <name>?" really
slows me down.

I'm using "n" to go to next message.  in 4.x, space would page down the message,
then go to the next message, and then would act like you hit "ok" in the
"Advance to next unread message in <name>?"

we've got to get space working again.  being able to read all your mail with
just the space bar rocks.

even with all that, I'm going to get a reviewer and land it on the trunk.

I'd like for laurel to be able to use / test what I've got so far.
another important part of this bug is that there was a pref that turned this on
and off in 4.x

this is cool a lot of people will be happy about this. BTW, alecf has a bug for
the spacebar if you want to take it. The bug number is in the bug that mpt
references in this bug report.
what was the pref?  I'll add that in.
I also need to figure out what to do when there are no more unread messages any
where.

(I'll go see what 4.x did)
after thinking about that patch, I realize I don't need the
nsIEnumerator2JSArray() crap.

I also think I have a good way to make it go across accounts.

I'll code up another patch and re-submit it.

this is cool. I applied the patch and had two comments.

The first is that it didn't actually go to my next folder it went to another
folder that had unread messages. I think this is because you are using
GetSubfolder which isn't currently sorted. Currently rdf does all of the sorting
for us.

The second is that it won't go to a subfolder if the parent is closed.(we have a
similar problem when loading the inbox on startup).

But, those two issues aside, this is going to make a lot of people happy.
ok, I've removed that nsIEnumerator2JSArray() sillyness.

I also added a call to make sure that the next unread header we auto-select is
visible.

I'm going to land what I've got, and then work on the cross-accounts bit and the
known problems.

thanks for trying it out, putterman.

I've landed my patch.  putterman, do you remember the pref that disabled this in
4.x?
I guess I'm wrong. Apparently this pref didn't exist in 4.x. I thought I'd heard
it did, but it doesn't exist on Windows at least.
This is great. It will make reading news a much more pleasant experience as soon
as the final issues are ironed out.

Do you open new bugs for the known issues?

that last patch makes it go across accounts.

currently, that patch will search the original server twice.
that's not that bad, since it will just ask all the top level folders
if they (or their children) have any unread messages (which they shouldn't)

one optimizations would be to check to make sure we don't search
the original server twice.

the biggest problem I see right now is the one putterman reported ealier:

"The second is that it won't go to a subfolder if the parent is closed.(we have
a similar problem when loading the inbox on startup)."

the out-of-order problem is not good, but not nearly as bad as that one.

this feature really exposes our need for need better folder loading performance.
daniel:  I haven't logged bugs on the issues yet.

one more problem:  there is an existing bug where we get the unread counts wrong
for some newsgroups.  (I'm sure it is assigned to me.)

it's annoying to switch into a folder only to find there are no new messages.

see http://bugzilla.mozilla.org/show_bug.cgi?id=34406

once I log bugs on all these issues, I'll mark this bug fixed.

until then, feel free to dump other issues into this bug report.
cc'ing jglick.

jglick, are there rules about where "next unread message" should go in the spec?

#34406 really rains on my parade.

once you get into a newsgroups with a bad unread count, navigation stops because
when we go to FindNextFolder() we just find the current group, because it has an
unread count of > 0.
Depends on: 34406
until I fix 34406, there is a work around.  if you mark all headers read, it
sets the count to 0.

it's lame, but at least it gets next navigation working.
another issue:  don't advance to unread messages in the trash.

thanks to laurel for pointing this out.

Seth, no there currently isn't anything in the spec about "next unread message". 
I can add it though.  Sounds like you have:

1. Next unread message in the same folder
2. Next unread message in a subfolder
3. Next unread message in the next folder for the same account (repeat as 
needed)
4. Next unread message in a subfolder of #3 (repeat as needed)
5. Next unread message in the next folder for the next account.
Next unread message works for me (using imap folders) but the next message is
not highlighted in the "subject" pane when moving from one folder to the next.
this is fixed, but I still have to log bugs on all the sub-bugs that still
remain before I mark it fixed.  I hope to do that today.
FYI:
bug 19254 is about the new flag not bubbling up to parent folder
bug 60776 is about not navigating to Trash folder
More FYI:
bug 60782 is about not landing on a collapsed folder/account structure
are the other bugs sufficient? Can we mark this fixed now?
I think all bugs are logged.  I'll close this one.
Marking fixed/verified.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: