PiP is fullscreen when launched from a full screen window
Categories
(Core :: Widget: Cocoa, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox-esr102 | --- | unaffected |
firefox103 | + | fixed |
firefox104 | --- | disabled |
firefox105 | --- | disabled |
People
(Reporter: yoasif, Assigned: KrisWright)
References
(Regression)
Details
(Keywords: leave-open, regression)
Attachments
(2 files)
9.01 MB,
video/quicktime
|
Details | |
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
dmeehan
:
approval-mozilla-release+
|
Details | Review |
Steps to reproduce:
- Navigate to https://www.youtube.com/watch?v=E31fNqvEWTk
- Click "full screen" button in Firefox window (green window decoration)
- Play video
- Click PiP button overlay in Firefox
What happens:
The PiP window opens in a new fullscreen window and doesn't act like a PiP window (doesn't overlay other windows if moved to a different screen, for example).
Expected result:
As prior to regression.
19:05.56 INFO: Narrowed inbound regression window from [430c8dbe, 8e63cdd5] (3 builds) to [430c8dbe, 709f48d5] (2 builds) (~1 steps left)
19:05.56 INFO: No more inbound revisions, bisection finished.
19:05.56 INFO: Last good revision: 430c8dbe41323dd546c10160706b52d118ef6361
19:05.56 INFO: First bad revision: 709f48d5b8373bf1547db9566f120fbddc5bddf4
19:05.56 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=430c8dbe41323dd546c10160706b52d118ef6361&tochange=709f48d5b8373bf1547db9566f120fbddc5bddf4
I tested this on macOS 10.15.7 (19H1922) - I have not tried other macOS versions, so the behavior may be different elsewhere.
![]() |
||
Comment 1•6 months ago
|
||
Bug 1781483 seems duplicated
Updated•6 months ago
|
Comment 2•6 months ago
|
||
Set release status flags based on info from the regressing bug 1700674
Comment 3•6 months ago
|
||
:KrisWright, since you are the author of the regressor, bug 1700674, could you take a look?
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 4•6 months ago
|
||
Someone is seeing this on macOS 11.6 as well: https://www.reddit.com/r/firefox/comments/w9lkua/picture_in_picture_mode_goes_into_full_screen/
Attaching a recording of behaviour that I believe to be linked to this issue. This was tested on MacOS 11.6 with a 2 screen setup, with the source video open in a fullscreen window (via green button). (Video was also cropped to reduce file size)
Updated•6 months ago
|
Comment 7•6 months ago
|
||
Tracking for 103 dot release potential - S2 severity.
Is backing out the regressor an option for release?
Comment 8•6 months ago
|
||
(In reply to Donal Meehan [:dmeehan] from comment #7)
Is backing out the regressor an option for release?
This seems like an option to me, but the best person to answer this question would be the author of bug 1700674, Kris.
Comment 9•6 months ago
|
||
The bug is marked as tracked for firefox103 (release). However, the bug still isn't assigned.
:gcp, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.
For more information, please visit auto_nag documentation.
Updated•6 months ago
|
Assignee | ||
Comment 10•6 months ago
|
||
Based on prior discussion it looks like the best fix until we know what's going on here is to back out bug 1700674.
Assignee | ||
Comment 11•6 months ago
|
||
Assignee | ||
Comment 12•6 months ago
|
||
Adding leave-open
since this backout doesn't address the underlying issue caused in bug 1700674.
Comment 14•6 months ago
|
||
Pushed by kwright@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ddf86a7ed4d8 Backout bug 1700674. r=mhowell
Assignee | ||
Comment 15•6 months ago
•
|
||
Comment on attachment 9287977 [details]
Bug 1781830 - Backout bug 1700674. r?mhowell
Beta/Release Uplift Approval Request
- User impact if declined: Users will continue experiencing picture-in-picture issue
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- Navigate to https://www.youtube.com/watch?v=E31fNqvEWTk
- Click "full screen" button in Firefox window (green window decoration)
- Play video
- Click PiP button overlay in Firefox
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This patch simply reverts the regressing patch to address regressions until we know what's going on.
- String changes made/needed:
- Is Android affected?: No
Comment 16•6 months ago
|
||
bugherder |
Comment 17•6 months ago
|
||
Comment on attachment 9287977 [details]
Bug 1781830 - Backout bug 1700674. r?mhowell
Approved for 104.0b5
Comment 18•6 months ago
|
||
bugherderuplift |
Updated•6 months ago
|
Comment 19•6 months ago
|
||
Comment on attachment 9287977 [details]
Bug 1781830 - Backout bug 1700674. r?mhowell
Approved for 103.0.2, thanks.
Comment 20•6 months ago
|
||
bugherderuplift |
Updated•5 months ago
|
Updated•5 months ago
|
Comment 22•4 months ago
|
||
The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:KrisWright, could you consider increasing the bug severity?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•4 months ago
|
Description
•