1782392 - Message search (Ctrl+Shift+F) does not allow searching on attachment status.

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Matt]

I am filing this as a trunk bug, but it reproduced equally in V102.1 and trunk.

Thunderbird
Version 105.0a1
Build ID 20220727102511
Update Channel nightly
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Thunderbird/105.0a1

Name Thunderbird
Version 102.1.0
Build ID 20220725200630
Update Channel release
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0
OS Windows_NT 10.0 19044

Steps to reproduce.
Access the advanced search and try and set the search criteria to attachment status.

Selecting the match of attachment status in the dialog immediately displays the is and a non existent filter criteria.

Image here https://user-media-prod-cdn.itsre-sumo.mozilla.net/uploads/images/2022-07-30-23-33-33-911af7.png

The error console shows the following entries for each attempt to select the Attachment status.

Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]", result: 2147500037, filename: "chrome://messenger/content/searchWidgets.js", lineNumber: 725, columnNumber: 0, data: null, stack: "_createMenulist@chrome://messenger/content/searchWidgets.js:725:36\nsetInput@chrome://messenger/content/searchWidgets.js:824:38\nupdateDisplay@chrome://messenger/content/searchWidgets.js:1035:16\nset searchAttribute@chrome://messenger/content/searchWidgets.js:1102:12\nset parentValue@chrome://messenger/content/searchWidgets.js:1085:7\nset value/<@chrome://messenger/content/searchWidgets.js:369:11\nset value@chrome://messenger/content/searchWidgets.js:367:22\nonSelect@chrome://messenger/content/searchWidgets.js:492:9\n", location: XPCWrappedNative_NoHelper }
searchWidgets.js:725

and

Element.releaseCapture() is deprecated. Use Element.releasePointerCapture() instead. For more help https://developer.mozilla.org/docs/Web/API/Element/releasePointerCapture menupopup.js:166:13

Comment 1

[b1]

https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/1782392-typo-attachment-search.patch
Typo caused here https://hg.mozilla.org/comm-central/rev/6bcfde504ba5#l9.157 in bug 1588155.

Comment 2

[Magnus Melin [:mkmelin] (away until Aug 10)]

Attachment: Bug 1782392 - Fix cut/paste error in string name for attachment status search. r=henry

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/1782392-typo-attachment-search.patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/99259a757720
Fix cut/paste error in string name for attachment status search. r=henry

Comment 4

[Magnus Melin [:mkmelin] (away until Aug 10)]

Comment on attachment 9287863 [details]
Bug 1782392 - Fix cut/paste error in string name for attachment status search. r=henry

[Approval Request Comment]
Regression caused by (bug #): bug 1588155
User impact if declined: can't search or set up filter for attachment status
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9287863 [details]
Bug 1782392 - Fix cut/paste error in string name for attachment status search. r=henry

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 104.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b2a6e86adc06

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9287863 [details]
Bug 1782392 - Fix cut/paste error in string name for attachment status search. r=henry

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.2.0:
https://hg.mozilla.org/releases/comm-esr102/rev/ef4d34e9585a