1786117 - Use ErrorContext-variant of `ReportOutOfMemory` in Stencil XDR

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

bug 1782569 adds ErrorContext-variant of ReportOutOfMemory.

Stencil XDR is also used by off-thread API, to decode Stencil XDR off-thread.
The code path also needs to use ErrorContext.

Things to do here:

• Add ErrorContext* ec field, ErrorContext* ec() method to js::XDRBufferBase
• Add ErrorContext* ec parameter to XDRBufferBase and all subclasses constructors
• Add ErrorContext* ec parameter to js::XDRState and subclasses constructors
• Let each consumer provide ErrorContext* parameter to each subclass of XDRState (e.g. js::XDRStencilDecoder)
• Use xdr->ec() instead of xdr->cx() when calling ReportOutOfMemory in StencilXdr.cpp

Comment 1

[Mohamed Atef]

Attachment: Bug 1786117: Use ErrorContext-variant of `ReportOutOfMemory` in Stencil XDR. r?arai

Comment 3

[Bryan Thrall [:bthrall]]

It is fine with me if we proceed with this or with my changes on bug 1783951. I marked this as duplicate without thinking about which one we should use.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7284cca9b538
Use ErrorContext-variant of `ReportOutOfMemory` in Stencil XDR. r=arai,bthrall

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7284cca9b538