Closed Bug 1782725 Opened 2 years ago Closed 2 years ago

Clicking on some emails causes long rendering delays / pause and Not Responding messages after updating to 104.0b2

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Version:
Thunderbird 104
Platform:
x86_64
Windows 10
Type:
defect

Tracking

(thunderbird_esr102 fixed, thunderbird104 wontfix)

Status:
VERIFIED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 --- fixed
thunderbird104 --- wontfix

People

(Reporter: thee.chicago.wolf, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: perf, regression)

Attachments

(1 file)

Bug 1782725 - Fix slowness in finding a contact matching an email address. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-esr102+
Details | Review

STR:

I am only seeing this delay and able to repro on emails that came from 1) the same sender and that 2) have the same subject line as well. For example, I get alerts from my credit card company of purchase activity. So the sender is the same (CC company) and their subject line is the same (new purchase activity). A delay repros for those emails but not the Not Responding issue.

  1. Update from 104.0b1 to 104.0b2
  2. Visit you Inbox and look for emails that have the same sender and same subject. Typically if it is a recurring email that you receive.

I took a perf profile of the event when it happens. It's here: https://share.firefox.dev/3PVxcqc

On my home PC, I was able to repro as well. Before updating to 104.0b2 on my home PC, I was able to click on the emails that would cause a delay in rendering and Not Responding messages to occur and they displayed almost instantly. After bumping to 104.0b2, the very same emails delayed rending and caused TB to enter a Not Responding state. It took around 15-20 seconds before TB recovered and displayed the email.

I tested clicking on other emails just randomly and there is a gamut of near instantly displaying to a slight delay in displaying. Whatever change this was, it regressed email rendering.

Summary: After updating to 104.0b2, clicking on some emails causes long rendering delays / pause and Not Responding messages → Clicking on some emails causes long rendering delays / pause and Not Responding messages after updating to 104.0b2

The majority of active is in address book land. For example cardForEmailAddress.
Any thoughts on why that might be?

Keywords: perf

Still present in 104.0b3.

I thought this might happen.

Regressed by: 1777156

How big are your address books, Arthur? I'm curious how big they need to be before this becomes a problem.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
  • Avoided parsing the vCards of cards that are never going to match.
  • Removed DisplayNameUtils.getCardForEmail and replaced it with MailServices.ab.cardForEmailAddress which is cached and therefore much faster.
  • Fixed two known problems with the cache.

(In reply to Geoff Lankow (:darktrojan) from comment #4)

How big are your address books, Arthur? I'm curious how big they need to be before this becomes a problem.

How do I get an address book entries count? I can tell you how big once I know how to do that.

Err, nevermind. I exported Personal Addy Book to CSV and it shows 5277 entries.

(In reply to Geoff Lankow (:darktrojan) from comment #3)

I thought this might happen.

Any insight into what might have changed between 104 b1 and 104 b2 that may have caused it?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c0c7472eadd0
Fix slowness in finding a contact matching an email address. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

(In reply to Arthur K. [He/Him] from comment #8)

(In reply to Geoff Lankow (:darktrojan) from comment #3)

I thought this might happen.

Any insight into what might have changed between 104 b1 and 104 b2 that may have caused it?

I marked bug 1777156 as causing this regression when I made the comment.

Also, you have a huge number of contacts! Must be really popular. :-)

Target Milestone: --- → 105 Branch

Would this also impact speed of spam processing when address book whitelisting is in efffect?
And filtering speed when using "is in my address book"?

Flags: needinfo?(geoff)

Probably, yes. I can't see where the filtering code uses the code in question but I assume it does. I can see that the spam whitelisting code does.

Flags: needinfo?(geoff)

TCW,
Better now?

Flags: needinfo?(thee.chicago.wolf)

(In reply to Geoff Lankow (:darktrojan) from comment #10)

(In reply to Arthur K. [He/Him] from comment #8)

(In reply to Geoff Lankow (:darktrojan) from comment #3)

I thought this might happen.

Any insight into what might have changed between 104 b1 and 104 b2 that may have caused it?

I marked bug 1777156 as causing this regression when I made the comment.

Also, you have a huge number of contacts! Must be really popular. :-)

This is likely the accumulation of 20+ years of emails. I'm sure that 90% of the ones in my addy book I don't use. Is there some facility or mechanism by which I can figure out which gathered email addresses haven't been used in X amount of years and just cull them?

Flags: needinfo?(thee.chicago.wolf)

The fix for this wasn't uplifted to 104.0b4, right?

Correct. Will be in the first 105 beta next week.

status-thunderbird104: affected → wontfix

Just loaded 105.0b1 at home and tested a few of the culprit emails that were having issues and this seems to be gone. I'll test on my work PC and if it's gone there I'll considered this resolved.

I have this 'not responding' issue since b2 and it happens when I select any group of messages, none in particular like the OP here. It's a full one-second count for every message selected before I get control again. If I select 30 messages it's a 30 second wait, a few screen flashes, a not responding message and then, when it's ready, the selected messages appear in the window below ready for deleting. I sure do hope that 105 solves this because it's gotten to the point where I just don't have the time to delete all the built-up messages that need to be deleted.

(In reply to JmG from comment #19)

I have this 'not responding' issue since b2 and it happens when I select any group of messages, none in particular like the OP here. It's a full one-second count for every message selected before I get control again. If I select 30 messages it's a 30 second wait, a few screen flashes, a not responding message and then, when it's ready, the selected messages appear in the window below ready for deleting. I sure do hope that 105 solves this because it's gotten to the point where I just don't have the time to delete all the built-up messages that need to be deleted.

I should add here that even selecting a single message for viewing in the view window takes - time - to show.

Confirming here at my work PC that the new 105.0b1 build no longer exhibits this issue. The very same slow loading / not responding emails load lightning fast.

(In reply to JmG from comment #19)

I have this 'not responding' issue since b2 and it happens when I select any group of messages, none in particular like the OP here. It's a full one-second count for every message selected before I get control again. If I select 30 messages it's a 30 second wait, a few screen flashes, a not responding message and then, when it's ready, the selected messages appear in the window below ready for deleting. I sure do hope that 105 solves this because it's gotten to the point where I just don't have the time to delete all the built-up messages that need to be deleted.

105.0b1 solved this for me. If you know where to grab it, do give it a shot once it's available or see if it's offered to you via Help > About Thunderbird.

HELP -> ABOUT tells me I'm still up to date on 104.0b4

The files are here, I think:

https://hg.mozilla.org/releases/mozilla-beta/file/d965b00277d83468d34c0968cb334d1333848914

But I have no idea what to do with all that. I'll wait. Patiently. And hope to the fates this solves this problem.

Status: RESOLVED → VERIFIED

105.0b1 solved the long delay in selecting messages problem that arose in 104.0b2

Thank you.

See Also: → 672835

Comment on attachment 9289418 [details]
Bug 1782725 - Fix slowness in finding a contact matching an email address. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1777156, must be uplifted if that bug is
User impact if declined: everything slows down
Testing completed (on c-c, etc.): in 105b1
Risk to taking this patch (and alternatives if risky): a little

Attachment #9289418 - Flags: approval-comm-esr102?

Comment on attachment 9289418 [details]
Bug 1782725 - Fix slowness in finding a contact matching an email address. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Attachment #9289418 - Flags: approval-comm-esr102? → approval-comm-esr102+
See Also: → 1836180
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: