1786646 - Add targeting in ASRouter for "colorways active" and "user has not set up colorways"

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

We'll need to be able to target messages based on whether or not colorways are active in for the initial feature callout tour in about:firefoxview. We'll want to combine this with additional targeting for "user has not set up colorways" to target reminder callouts in bug 1786347.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1786646 - Add targeting in ASRouter for "colorways active" and "user has not set up colorways"

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/500d9526b586
Add targeting in ASRouter for "colorways active" and "user has not set up colorways" r=pdahiya

Comment 3

[Cristian Tuns]

Backed out for causing xpcshell failures test_backgroundtask_targeting.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_targeting.js | test_targeting - [test_targeting : 16] 0 == 11

Comment 4

[Meg Viar [:mviar]]

Thanks for flagging Cristian, sorry I missed this in the try push. I've addressed the issue and will attempt to re-land after my change is reviewed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6d6bf1928d4
Add targeting in ASRouter for "colorways active" and "user has not set up colorways" r=pdahiya,nalexander

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b6d6bf1928d4

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b6d6bf1928d4

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verfied this enhancement and I can confirm the following:

• The "colorwaysActive" and the "userEnabledActiveColorway" targeting parameters are successfully displayed in the ASRouter page.
• The "userEnabledActiveColorway" parameter is set to "true" if a colorway theme is enabled.
• The "userEnabledActiveColorway" parameter is set to "false" if a default theme is enabled.

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220829094551) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.

Also, I have observed that the "userEnabledActiveColorway" parameter has no value if a custom theme is enabled, however, I have logged a separate issue for this scenario (see Bug 1787783 )