1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

The existing feature callout message should be broken out into five potential messages (n/n refers to step indicator progress):

Shown when colorways active:
- start with first screen 1/3
- start with second screen 2/3
- start with third screen & final CTA 3/3

Show when colorways not active (using new targeting):
- start with first screen 1/2
- start with second screen, but with final CTA 2/2

When the feature callout's parent page loads, is focused, or when the screen of the callout message is advanced, reach out to ASRouter for the next appropriate message, if any. The messages above will need to be assigned appropriate targeting based on the current state of this pref as well as new targeting for whether colorways is active from bug 1786646.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56ba242e0732
Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing python fxms failures . CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line : ValueError: Schemas do not match!

Comment 4

[Meg Viar [:mviar]]

Thanks for flagging, I think I understand the issue. Here's a new try push to test that the fix resolves the failure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f20cb6ec2df08ccd8a51d3b68e627c348881e1d7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba0784c1646a
Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for fxms failures

• backout: https://hg.mozilla.org/integration/autoland/rev/2620d8fca26c54f671f1123d0d403d982b019d10
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Xb0oGGFxSP-bijsaNz8t-w.0&revision=ba0784c1646a9fd48528a9dc6d1b9f6797fc510f
• failure log: https://treeherder.mozilla.org/logviewer?job_id=388796466&repo=autoland&lineNumber=3470

[task 2022-08-29T16:47:02.486Z]     "localizedText": {
[task 2022-08-29T16:47:02.486Z]       "type": "object",
[task 2022-08-29T16:47:02.486Z]       "properties": {
[task 2022-08-29T16:47:02.486Z]         "string_id": {
[task 2022-08-29T16:47:02.486Z]           "description": "Id of localized string to be rendered.",
[task 2022-08-29T16:47:02.486Z]           "type": "string"
[task 2022-08-29T16:47:02.486Z]         }
[task 2022-08-29T16:47:02.486Z]       },
[task 2022-08-29T16:47:02.486Z]       "required": [
[task 2022-08-29T16:47:02.486Z]         "string_id"
[task 2022-08-29T16:47:02.486Z]       ]
[task 2022-08-29T16:47:02.486Z]     },
[task 2022-08-29T16:47:02.486Z]     "localizableText": {
[task 2022-08-29T16:47:02.486Z]       "description": "Either a raw string or an object containing the string_id of the localized text",
[task 2022-08-29T16:47:02.486Z]       "oneOf": [
[task 2022-08-29T16:47:02.486Z]         {
[task 2022-08-29T16:47:02.486Z]           "type": "string",
[task 2022-08-29T16:47:02.486Z]           "description": "The string to be rendered."
[task 2022-08-29T16:47:02.486Z]         },
[task 2022-08-29T16:47:02.486Z]         {
[task 2022-08-29T16:47:02.486Z]           "$ref": "resource://activity-stream/schemas/MessagingExperiment.schema.json#/$defs/localizedText"
[task 2022-08-29T16:47:02.486Z]         }
[task 2022-08-29T16:47:02.486Z]       ]
[task 2022-08-29T16:47:02.486Z]     }
[task 2022-08-29T16:47:02.486Z]   }
[task 2022-08-29T16:47:02.486Z] }Traceback (most recent call last):
[task 2022-08-29T16:47:02.486Z]   File "make-schemas.py", line 456, in <module>
[task 2022-08-29T16:47:02.486Z]     main(args.check)
[task 2022-08-29T16:47:02.486Z]   File "make-schemas.py", line 437, in main
[task 2022-08-29T16:47:02.486Z]     check_diff(schema_def, schema)
[task 2022-08-29T16:47:02.486Z]   File "make-schemas.py", line 389, in check_diff
[task 2022-08-29T16:47:02.486Z]     raise ValueError("Schemas do not match!")
[task 2022-08-29T16:47:02.486Z] ValueError: Schemas do not match!
[task 2022-08-29T16:47:02.491Z] Creating default state directory: /builds/worker/.mozbuild
[taskcluster 2022-08-29 16:47:02.862Z] === Task Finished ===
[taskcluster 2022-08-29 16:47:02.862Z] Unsuccessful task run with exit code: 1 completed in 21.081 seconds

Comment 7

[Meg Viar [:mviar]]

Apologies @natalia, that was clearly still failing in my treeherder link. Here's a new try for the failing test after adding the message description in both schemas: https://treeherder.mozilla.org/jobs?repo=try&revision=1c085309bf3e7886198b1a9d09ab6be034df1d9a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/225b8bbe0912
Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak

Comment 9

[Sandor Molnar[:smolnar]]

Backed out changeset 225b8bbe0912 (bug 1786647) for causing browser-chrome failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/da4a79db4d0acba5fd7b7ef2b9debe69ad513072

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js | Uncaught exception in test - at :0 - SyntaxError: JSON.parse: expected double-quoted property name at line 235 column 15 of the JSON data

Comment 10

[Meg Viar [:mviar]]

I've made updates to address that failure caused my recent changes and will attempt to land again.
Here's the resulting full try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f00daa7975b7b535e7ec6204c54194330a1f18c

We're trying to sort out an issue where the failing test cited above is not running on try, even when the job is explicitly selected. We have a discussion open in Matrix. I have tested it locally however, and confirmed that test is now passing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1688ec45e15f
Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1688ec45e15f

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Feature Callout" screens respect the specification from the received Test Plan.

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220901095452) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.