1951680 - Using the Delete column in the "Search Messages…" window may also delete other messages and may break keyboard navigation.

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Open the context menu of a real folder and select "Search Messages…".
2. Click on the icon with the tooltip "Select columns to display" and enable "Delete".
3. Enter a search term that will return results.
4. Multi-select two or more messages.
5. Click on the trash icon of one of the selected messages.
6. Click on the trash icon of an unselected message.
7. Press the up or down arrow key.

Expected result:
After step 5, only the clicked message is being deleted.
After step 6, the clicked message is being deleted, keyboard navigation remains functional.

Actual result:
After step 5, all selected messages are being deleted.
After step 6, the clicked message is being deleted, but keyboard navigation does not remain functional.
After step 7, the error console displays

Error: We do not implement timed selection. TreeSelection.mjs:205:11
    timedSelect chrome://messenger/content/TreeSelection.mjs:205
    _moveByOffset chrome://global/content/elements/tree.js:1437
    setupEventListeners chrome://global/content/elements/tree.js:955
Uncaught NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "We do not implement timed selection." {file: "chrome://messenger/content/TreeSelection.mjs" line: 205}]'[JavaScript Error: "We do not implement timed selection." {file: "chrome://messenger/content/TreeSelection.mjs" line: 205}]' when calling method: [nsITreeSelection::timedSelect]
    _moveByOffset chrome://global/content/elements/tree.js:1437
    setupEventListeners chrome://global/content/elements/tree.js:955
tree.js:1437
    _moveByOffset chrome://global/content/elements/tree.js:1437
    setupEventListeners chrome://global/content/elements/tree.js:955

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1951680 - Fix handling of delete column in "Search Messages…" and remove unused code. r=#thunderbird-reviewers

• Fix handleDeleteColClick so that only the clicked message is deleted and the previous selection is restored correctly.
• Remove the nsIMsgDBViewCommandUpdater interface from the FolderDisplayWidget, as it is actually not being used anymore since changing nsMsgDBView::mCommandUpdater to nsWeakPtr in Bug 1812494.
• Remove other unused code.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Try

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc64856546ff
Fix handling of delete column in "Search Messages…" and remove unused code. r=mkmelin

Comment 4

[Wayne Mery (:wsmwk)]

Hartmut, this has been through beta, but not been out in release channel. Can you assess and mark uplift potential for 128?

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Attachment: D240340.esr128.diff

[User impact if declined]

• Using the Delete column in the "Search Messages…" window may also delete other messages and may break keyboard navigation.

[Is this code covered by automated tests?]

• No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Verified in Daily and Beta by myself.

[Needs manual test from QA?]

• Yes
• STR see comment 0.

[Risk to taking this patch]

• Low.

[Why is the change risky/not risky? (and alternatives if risky)]

• Changes are contained to the search messages window.

[String changes made/needed]

• none

Comment 6

[Corey Bryant]

Comment on attachment 9478911 [details] [diff] [review]
D240340.esr128.diff

[Triage Comment]
Approved for esr128

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 128.10.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/ae473e8f64fb