Closed Bug 1795286 Opened 1 year ago Closed 1 year ago

All bookmarks are put in an overflow menu when placed in the main toolbar

Categories

(Firefox :: Theme, defect)

Firefox 107
defect

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox106 --- unaffected
firefox107 --- unaffected
firefox108 --- verified

People

(Reporter: tgnff242, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

Open "Customise toolbar..." and move the "Bookmarks toolbar items" to the main toolbar (eg. right next to the urlbar).

Actual results:

Regardless of the number of items (even a single item), the size of the window, other extension icons etc, all bookmarks are put under a "Show more bookmarks" icon.

Expected results:

It should show as many bookmark items as they can fit.

This is a regression from Bug 1790616.

Has STR: --- → yes
Component: Untriaged → Theme
Regressed by: 1790616

Additionally, when a folder has more items that can vertically fit on the screen, you can't scroll to see them any more.

Also, not particularly important, but the profile manager (firefox -p), is unnecessarily horizontally larger than before.

(In reply to tgn-ff from comment #1)

Additionally, when a folder has more items that can vertically fit on the screen, you can't scroll to see them any more.

Please file separate bug for this?

Also, not particularly important, but the profile manager (firefox -p), is unnecessarily horizontally larger than before.

That's bug 1795224, separate regression, but I'm also looking at it, thanks.

Assignee: nobody → emilio
Flags: needinfo?(emilio)

This preserves the min-width behavior that XUL had. Note that this
depends on D159377

Flags: needinfo?(emilio)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0645b630915e
Improve how bookmarks toolbar items flex. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Set release status flags based on info from the regressing bug 1790616

I've filed Bug 1795294 about the scrolling part.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

I have reproduced this issue with only one bookmark, using an affected Nightly build from 2002-10-14, on Ubuntu 21.04.
Verified as fixed on Firefox 108.0b4 (20221120185746) on the above mentioned OS.

Flags: qe-verify+
Regressions: 1850352
You need to log in before you can comment on or make changes to this bug.