1797585 - Port bug 1727820 - Updater overhaul to deal with race conditions

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Rob Lemley [:rjl]]

This ought to be fun...

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1797585 - Port bug 1727820: Update enterprisepolicy tests. r=#thunderbird-reviewers

Port of D159295 & D159308.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1797585 - Port bug 1727820: Drop AppUpdateUI.jsm in favor of UpdateListener.jsm from toolkit. r=#thunderbird-reviewers

AppUpdateUI.jsm is a hard-to-maintain combination of AppUpdater.jsm from browser
and UpdateListener.jsm from toolkit. Replacing it with the same code that Firefox
is running will make future maintenance easier.

Depends on D160427

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1797585 - Port bug 1727820: Change aboutDialog-appUpdater to work with AppUpdater. r=#thunderbird-reviewers

Depends on D160428

Comment 4

[Rob Lemley [:rjl]]

Here's a special try build that hopefully will update against the "nightlytest" channel one time using the new updater code.

https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=8d769fe47c8b10e5c3c181e072b806ad1202527d

Comment 5

[Rob Lemley [:rjl]]

One UI glitch, I didn't look too much into it. There's a badge that can/will appear on the AppMenu icon when there's an update, like Firefox has. Right now the actual badge looks funny. Probably needs icons. There's also missing strings to go with it I think.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3345b7e30014
Port bug 1727820: Update enterprisepolicy tests. r=mkmelin
https://hg.mozilla.org/comm-central/rev/87121f0605f6
Port bug 1727820: Drop AppUpdateUI.jsm in favor of UpdateListener.jsm from toolkit. r=mkmelin
https://hg.mozilla.org/comm-central/rev/3c0c7389ae69
Port bug 1727820: Change aboutDialog-appUpdater to work with AppUpdater. r=mkmelin

Comment 7

[Rob Lemley [:rjl]]

Reopening due to broken about dialog.

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1797585 - Keep loading brand.dtd in about dialog for now. r=#thunderbird-reviewers

aboutDialog.dtd refers to &brandShorterName thats found in brand.dtd.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1797585 - Fix throbber selector. r=rjl

Was causing Unknown namespace prefix ‘html’. Ruleset ignored due to bad selector.
From https://hg.mozilla.org/comm-central/diff/3c0c7389ae6990e663d7bcc98318c813c816e84b/mail/base/content/aboutDialog.css#l1.18

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3a88856c1346
Keep loading brand.dtd in about dialog for now. r=aleca

Comment 11

[Richard Marti (:Paenglab)]

The updater part in the prefs is completely missed by this bug.

Comment 12

[Richard Marti (:Paenglab)]

Attachment: Bug 1797585 - Port bug 1727820: Make the update part in the prefs working. r=#thunderbird-reviewers

Comment 13

[Richard Marti (:Paenglab)]

Attachment: Bug 1797585 - Port bug 1727820: Correctly style the icons. r=aleca

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3582397d5b4c
Fix throbber selector. r=rjl
https://hg.mozilla.org/comm-central/rev/2c4b35824be9
Port bug 1727820: Make the update part in the prefs working. r=mkmelin
https://hg.mozilla.org/comm-central/rev/75e84650e2b2
Port bug 1727820: Correctly style the icons. r=aleca