1798701 - AppMenu Update status badge and text need styles

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Rob Lemley [:rjl]]

Since bug 1797585, various update status' will be displayed in/on the AppMenu via a badge and some text that could appear at the top.

I believe we need to add some possible selectors to mail/themes/shared/mail/panelUI.css from browser/themes/shared/toolbarbutton-icons.css and browser/themes/shared/customizableui/panelUI-shared.css.

• badge-status="update-available"
• badge-status="update-downloading"
• badge-status="update-manual"
• badge-status="update-other-instance"
• badge-status="update-restart"

Currently the badge shows up as a red blob, and the line of text looks very out of place.

I will try to get screenshots and some more specifics as to what is needed.

Comment 1

[Rob Lemley [:rjl]]

Attachment: image.png

Badge currently displayed

Comment 2

[Rob Lemley [:rjl]]

Ahh.. the text that appears has a missing string. I will see if I can find and add those in another bug.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: update-icon.png

I see it only for the badge-status="update-restart".

A problem of the badge in the AppButton could be that we have no corresponding entries in the AppMenu for restart.

Alessandro, we have actually the update icon in the title bar (see image). Should we still style the AppButton badge?

Maybe we should implement the update functionality like FX has (you filed a bug for this but closed it again).

Comment 4

[Rob Lemley [:rjl]]

Attachment: image.png

Richard, are we looking at the same thing? You're up in the title bar it looks like, I'm just looking at the AppMenu.
This is what i see for Firefox's AppMenu.

Comment 5

[Rob Lemley [:rjl]]

Attachment: image.png

And this is how it's currently styled in Thunderbird.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Rob Lemley [:rjl] from comment #4)

Richard, are we looking at the same thing? You're up in the title bar it looks like, I'm just looking at the AppMenu.
This is what i see for Firefox's AppMenu.

Yes, we had the special update icon because we had no such functionality in in our AppMenu. Maybe with your changes this update icon does no more work and we can remove it.

(In reply to Rob Lemley [:rjl] from comment #5)

Created attachment 9301611 [details]
image.png

And this is how it's currently styled in Thunderbird.

Oh, didn't know we show now this info in the AppMenu.

Comment 7

[Rob Lemley [:rjl]]

(In reply to Richard Marti (:Paenglab) from comment #6)

And this is how it's currently styled in Thunderbird.

Oh, didn't know we show now this info in the AppMenu.

Yeah, it came with the recent updater changes.. sort of.. some of it came in with bug 1621841. It needs some updating though. Bug 1798761 should take care of it.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1798701 - Style the AppButton badge for badge-status="update-restart". r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1798701-app-meun-badged-ESR.patch

Patch for ESR to fix the typo.

Comment 10

[Alessandro Castellani [:aleca]]

Comment on attachment 9301826 [details] [diff] [review]
1798701-app-meun-badged-ESR.patch

Review of attachment 9301826 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this

Comment 11

[Richard Marti (:Paenglab)]

Comment on attachment 9301826 [details] [diff] [review]
1798701-app-meun-badged-ESR.patch

[Approval Request Comment]
User impact if declined: no hamburger icon shown when a badge is shown
Testing completed (on c-c, etc.): landing soon on c-c but has more changes than this typo fix
Risk to taking this patch (and alternatives if risky): low, typo fix

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/19393f477a6d
Style the AppButton badge for badge-status="update-restart". r=aleca

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9301826 [details] [diff] [review]
1798701-app-meun-badged-ESR.patch

[Triage Comment]
Approved for esr102

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/92b7dc937bba