1801824 - Rendering problem of accelerated canvas with android emulator in CI

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sotaro Ikeda [:sotaro]]

Found during Bug 1794380.

With android emulator in CI, accelerated canvas rendering had problems. The problems did not happen with android hardware in CI.

https://treeherder.mozilla.org/jobs?repo=try&revision=0e9b0fd6f7fdf62e6b2a259f98cfb6326df5bc3f

Comment 1

[Sotaro Ikeda [:sotaro]]

Updating emulator version became simple by Bug 1718341. Then just updating emulator version caused a lot of test failure.

• Test result of emulator of Adnroid 24(default)
• Test result of emulator of Adnroid 25
• Test result of emulator of Adnroid 27
• Test result of emulator of Adnroid 28
• Test result of emulator of Adnroid 30
• Test result of emulator of Adnroid 33

Comment 2

[Sotaro Ikeda [:sotaro]]

Latest Android emulator 33 addressed some test failures of accelerated canvas. But test failures of R-swr-nofis was not addressed.

• Test result of enabling accelerated canvas on emulator of Adnroid 24(default)
• Test result of enabling accelerated canvas on emulator of Adnroid 33

Comment 3

[Jamie Nicol [:jnicol] out of office until 6th Jan]

Sotaro, do you know whether accelerated canvas works on a device running Android 7 (SDK level 24)? ie is it actually an emulator problem, or is it a problem with older versions of Android?

Comment 4

[Sotaro Ikeda [:sotaro]]

I do not have an Android 7 device, but it should be an emulator specific problem.

From Bug 1794380 comment9, Android 8.0 Pixel2 did not cause the problem. By modifying test, it seems to possible to check if accelerated canvas works on Android 7.0 MotoG5.

Comment 5

[Sotaro Ikeda [:sotaro]]

From android 25 emulator, the followings R-nofis tests' failures were addressed. But several failures of R-swr-nofis were not addressed.

layout/reftests/border-radius/clipping-4-canvas.html
layout/reftests/border-radius/clipping-5-refc.html
layout/reftests/border-radius/intersecting-clipping-1-canvas.html
layout/reftests/border-radius/intersecting-clipping-1-refc.html

• accelerated canvas of emulator of Android 24
• accelerated canvas of emulator of Android 25
• accelerated canvas of emulator of Android 26
• accelerated canvas of emulator of Android 27

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)

But several failures of R-swr-nofis were not addressed.

It was caused by current implementation of RenderAndroidSurfaceTextureHost. On android emulator, single buffer mode SurfaceTexture is not used. Since single buffer mode SurfaceTexture does not work on Android Emulator.

• https://searchfox.org/mozilla-central/rev/d6a131ceb435c03ccab2592578f6e2ebf12c1644/gfx/gl/SharedSurfaceEGL.cpp#138

When SurfaceTexture is not single buffer mode, RenderAndroidSurfaceTextureHost calls mSurfTex->UpdateTexImage() in RenderAndroidSurfaceTextureHost::Lock(). It is necessary for video playback with hardware WebRender. But it does not work with WebRender (Software OpenGL).

Comment 7

[Sotaro Ikeda [:sotaro]]

test results of currrent m-c

• Android 24(default)
• Android 25
• Android 26
• Android 27
• accelerated canvas on Android 24(default)
• accelerated canvas on Android 25
• accelerated canvas on Android 26
• accelerated canvas on Android 27

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1801824 - Enable accelerated canvas on Android nightly

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: WIP: Bug 1801824 - Enable accelerated canvas on Android nightly and update Android emulator to 25

Comment 10

[Sotaro Ikeda [:sotaro]]

accelerated canvas seemed to cause timeout failures in Wd1 mda1 mda2 of debug build on Android emulator.

• https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=QsZ8qCzDSk-ynIXH41E6sw.0&revision=a4eba3174697c6938efc77e046bf4011b9e5ac77

Android emulator does not use hardware GPU. It seems to be related.

• https://searchfox.org/mozilla-central/rev/893a8f062ec6144c84403fbfb0a57234418b89cf/python/mozboot/mozboot/android-avds/x86_64.json#17

Comment 11

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=D3k4hhfgTXyXcA9JeDMyNw.0&revision=5eabab44405949c0694e9f2aa862e90ca36048bc

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d42a610802e0
Enable accelerated canvas on Android nightly r=lsalzman,gfx-reviewers,jmaher

Comment 13

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d42a610802e0