1802163 - Unable to drag images from Firefox and drop onto Apple Photos

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[:glob ✱]

Tested with Nightly 109.0a1 (2022-11-16) (64-bit) on macOS 13.0.1

Steps to reproduce:

1. Open a tab that contains an image in Firefox
2. Open Apple Photos
3. Drag the image from Firefox onto Photos

Expected result:

• Image added to Photos (under Imports)

Actual result:

• Nothing

Notes:

• Dragging the same image from Safari to Photos works without issue

Comment 1

[Tom S. (please needinfo tschuster)]

Is this a regression?

Comment 2

[:glob ✱]

(In reply to Tom Schuster [:evilpie] from comment #1)

Is this a regression?

I spot tested a handful of older versions - it appears to have never worked.

Comment 3

[Tom S. (please needinfo tschuster)]

Just to confirm: "Photos" is a macOS desktop application, right? bug 1801499 only applies to dragging images inside the same Firefox instance, not with to/from other applications.

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Tom Schuster [:evilpie] from comment #3)

Just to confirm: "Photos" is a macOS desktop application, right? bug 1801499 only applies to dragging images inside the same Firefox instance, not with to/from other applications.

Yes. However, I figured the two might still be connected in terms of what is advertised to the drag target.

Comment 5

[Edgar Chen [:edgar]]

I suspect it is something related the data we set into drag pasteboard.

I dump the data type in drag pasteboard the set by each browser while dragging a png image, https://upload.wikimedia.org/wikipedia/commons/b/b6/Image_created_with_a_mobile_phone.png.

Safari Version 15.5 (17613.2.7.1.8)

dyn.ah62d4rv4gu8yc6durvwwa3xmrvw1gkdusm1044pxqyuha2pxsvw0e55bsmwca7d3sbwu
Apple files promise pasteboard type
public.png
Apple PNG pasteboard type
com.apple.WebKit.custom-pasteboard-data
public.tiff
NeXT TIFF v4.0 pasteboard type
dyn.ah62d4rv4gu8zs3pcnzme2641rf4guzdmsv0gn64uqm10c6xenv61a3k
WebURLsWithTitlesPboardType
dyn.ah62d4rv4gu8yc6durvwwaznwmuuha2pxsvw0e55bsmwca7d3sbwu
Apple URL pasteboard type
public.url
CorePasteboardFlavorType 0x75726C20
public.url-name
CorePasteboardFlavorType 0x75726C6E
public.utf8-plain-text
NSStringPboardType
com.apple.flat-rtfd
NeXT RTFD pasteboard type
com.apple.webarchive
Apple Web Archive pasteboard type
dyn.ah62d4rv4gu8yc6durvwwaz5fqmf0w7baqv4045p3eb2gc65yqzvg82pwquuhk8puqy
Apple WebKit dummy pasteboard type
com.apple.pasteboard.promised-file-content-type
com.apple.pasteboard.promised-file-url
dyn.ah62d4rv4gu8y6y4usm1044pxqzb085xyqz1hk64uqm10c6xenv61a3k
NSPromiseContentsPboardType

Google Chrome Version 107.0.5304.110 (Official Build) (x86_64)

org.chromium.drag-dummy-type
dyn.ah62d4rv4gu8yc6durvwwaznwmuuha2pxsvw0e55bsmwca7d3sbwu
Apple URL pasteboard type
public.url-name
CorePasteboardFlavorType 0x75726C6E
public.url
CorePasteboardFlavorType 0x75726C20
dyn.ah62d4rv4gu8yc6durvwwa3xmrvw1gkdusm1044pxqyuha2pxsvw0e55bsmwca7d3sbwu
Apple files promise pasteboard type
public.png
Apple PNG pasteboard type
org.chromium.image-html
com.apple.pasteboard.promised-file-content-type
com.apple.pasteboard.promised-file-url
dyn.ah62d4rv4gu8y6y4usm1044pxqzb085xyqz1hk64uqm10c6xenv61a3k
NSPromiseContentsPboardType
public.tiff
NeXT TIFF v4.0 pasteboard type

Firefox 107.0 (64-bit)

com.apple.pasteboard.promised-file-url
dyn.ah62d4rv4gu8y6y4usm1044pxqzb085xyqz1hk64uqm10c6xenv61a3k
NSPromiseContentsPboardType
public.utf8-plain-text
NSStringPboardType
com.apple.pasteboard.promised-file-content-type
dyn.ah62d4rv4gu8yc6durvwwa3xmrvw1gkdusm1044pxqyuha2pxsvw0e55bsmwca7d3sbwu
Apple files promise pasteboard type
public.url-name
CorePasteboardFlavorType 0x75726C6E
public.tiff
NeXT TIFF v4.0 pasteboard type
dyn.ah62d4rv4gu8zs3pcnzme2641rf4guzdmsv0gn64uqm10c6xenv61a3k
WebURLsWithTitlesPboardType
public.html
Apple HTML pasteboard type
public.url
CorePasteboardFlavorType 0x75726C20
dyn.ah62d4rv4gu8yc6durvwwaznwmuuha2pxsvw0e55bsmwca7d3sbwu
Apple URL pasteboard type
org.mozilla.custom-clipdata
org.mozilla.MozillaWildcard

Comment 6

[Edgar Chen [:edgar]]

I suspect it is because we don't set image data into dragging pasteboard in https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/widget/cocoa/nsChildView.mm#4280-4389, switch to Widget: Cocoa.

Comment 8

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar] from comment #6)

I suspect it is because we don't set image data into dragging pasteboard in https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/widget/cocoa/nsChildView.mm#4280-4389, switch to Widget: Cocoa.

Bug 1814531 doesn't help here.
Or maybe it's because we always put empty string to com.apple.pasteboard.promised-file-url and com.apple.pasteboard.promised-file-content-type, see https://searchfox.org/mozilla-central/rev/1d447251b44b3a34ab4ca42b39d1f838bea60b33/widget/cocoa/nsClipboard.mm#731-734.

Comment 9

[Kai Dederichs]

Dunno how useful this is but I think here's how Chromium handles it:

https://github.com/chromium/chromium/blob/37023d304cab9bb1809bc99198057d3516f8634d/content/app_shim_remote_cocoa/web_drag_source_mac.mm#L107

It seems there's some strange thing with the Promise based drag and drop going on since you normally need some sort of NSFilePromiseProvider that handles file promises when the system actually requests them but they kinda got around it somehow.

Comment 10

[Kris Wright :KrisWright]

We actually have a problem with the code that sets the pasteboard data - it doesn't cover all current types, and so any data we want about the file promise isn't carried over. Photos specifically looks for the promise content type to see if the incoming data is of a type that it accepts before attempting an import. Not only do we not carry this information over, but we also don't carry over specific image data during a drag. Currently rewriting the required block of code to fix this.

Comment 11

[Kris Wright :KrisWright]

Attachment: WIP: test - Bug 1802163 - Describe png type for dragging a png.

Prompts import from photos by including more information from drag session.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 13

[Stephen A Pohl [:spohl]]

Attachment: Bug 1802163: Improve dragging of file URLs on macOS. r=#mac-reviewers

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/71bc35ab04f8
https://hg.mozilla.org/integration/autoland/rev/d9643ffd5088
Improve dragging of file URLs on macOS. r=mac-reviewers,mstange

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d9643ffd5088

Comment 16

[Monica Chiorean]

I was able to reproduce the issue on Mac12.6 using FF build 142.0a1(20250701091543).
Verified as fixed on Mac12.6 using FF build 144.0a1 and 143.0b5.