Closed Bug 1983136 Opened 5 months ago Closed 5 months ago

Drag and drop images to finder broken

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Version:
Firefox 143
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
144 Branch
Tracking Flags:
Tracking Status
firefox-esr128 --- unaffected
firefox-esr140 --- unaffected
firefox142 --- unaffected
firefox143 + fixed
firefox144 + fixed

People

(Reporter: jamienk, Assigned: spohl)

References

(Regression)

Details

(Keywords: dataloss, regression)

Attachments

(2 files, 1 obsolete file)

Bug 1983136: Fix a regression from bug 1802163 that prevented dropping of images into Finder on macOS. r=mstange!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1983136: Fix a regression from bug 1802163 that prevented dropping of images into Finder on macOS. r=mstange!
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:143.0) Gecko/20100101 Firefox/143.0

Steps to reproduce:

Drag and drop an image to the Desktop (or any folder). This worked yesterday, broke today 2025-08-14 Mac Nightly

Actual results:

It acts like it will save (green + etc)

Expected results:

It should save the image where dropped

pretty big deal as I thought it was saving. It just silently fails.

Component: Untriaged → Downloads API
Product: Firefox → Toolkit

Ran mozregression GUI (what a GREAT tool):

Got this hit:
Bug 1802163: Improve dragging of file URLs on macOS. r=mac-reviewers,mstange

Keywords: regression
Regressed by: 1802163
Component: Downloads API → Widget: Cocoa
Product: Toolkit → Core

:spohl, since you are the author of the regressor, bug 1802163, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(spohl.mozilla.bugs)

I'm unable to reproduce this at the moment. Could you please clarify what version of macOS that you're on? And can you provide a sample image that doesn't work for you? Thanks!

Severity: -- → S3
Flags: needinfo?(spohl.mozilla.bugs) → needinfo?(jamienk)

I'm on Mac OS Monterey 12.7.6 (21H1320)

All images fail from all website when I drag and drop them into the Finder. See this video:

https://youtu.be/mLs-TNfHRnk

Dragging & Dropping links works and results in .webloc files

I also seem to be able to drag and drop text resulting in .textClipping files

Flags: needinfo?(jamienk)

Thank you, I'm able to reproduce now. Looking into it!

Assignee: nobody → spohl.mozilla.bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Duplicate of this bug: 1983616

Set release status flags based on info from the regressing bug 1802163

status-firefox142: --- → unaffected
status-firefox143: --- → affected
status-firefox144: --- → affected
status-firefox-esr128: --- → unaffected
status-firefox-esr140: --- → unaffected
Keywords: dataloss

The bug is marked as tracked for firefox143 (beta) and tracked for firefox144 (nightly). However, the bug still has low severity.

:jstutte, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(jstutte)

I have this isolated and believe to have a fix. Will upload patch shortly.

Severity: S3 → S2
Flags: needinfo?(jstutte)

This reverts back to using the lower-level Pasteboard APIs to retrieve the paste location from the pasteboard when one is present. It turns out that Cocoa APIs are unable to retrieve the paste location. This patch also reintroduces support for kPasteboardTypeFileURLPromise, which seemed to be a no-op while working on bug 1802163 but is clearly used by apps such as Finder.

This reverts back to using the lower-level Pasteboard APIs to retrieve the paste location from the pasteboard when one is present. It turns out that Cocoa APIs are unable to retrieve the paste location. This patch also reintroduces support for kPasteboardTypeFileURLPromise, which seemed to be a no-op while working on bug 1802163 but is clearly used by apps such as Finder.

Original Revision: https://phabricator.services.mozilla.com/D261840

Attachment #9508312 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: Dropping of images into Finder on macOS will be broken (regression)
  • Code covered by automated testing: no
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: n/a
  • Risk associated with taking this patch: Minimal.
  • Explanation of risk level: This restores code and functionality that existed prior to the regression from bug 1802163.
  • String changes made/needed: none
  • Is Android affected?: no
Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/eae1e3307218 https://hg.mozilla.org/integration/autoland/rev/ec7a53992afc Fix a regression from bug 1802163 that prevented dropping of images into Finder on macOS. r=mstange
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/45e2096bf5fd https://hg.mozilla.org/integration/autoland/rev/4b31d9dac162 Revert "Bug 1983136: Fix a regression from bug 1802163 that prevented dropping of images into Finder on macOS. r=mstange" for causing build bustages in nsCocoaWindow.mm

Backed out for causing build bustages

Flags: needinfo?(spohl.mozilla.bugs)
Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a76c4aa96f82 https://hg.mozilla.org/integration/autoland/rev/7fed0a3528ef Fix a regression from bug 1802163 that prevented dropping of images into Finder on macOS. r=mstange
Attachment #9508312 - Attachment is obsolete: true
Attachment #9508312 - Flags: approval-mozilla-beta?

This reverts back to using the lower-level Pasteboard APIs to retrieve the paste location from the pasteboard when one is present. It turns out that Cocoa APIs are unable to retrieve the paste location. This patch also reintroduces support for kPasteboardTypeFileURLPromise, which seemed to be a no-op while working on bug 1802163 but is clearly used by apps such as Finder.

Original Revision: https://phabricator.services.mozilla.com/D261840

Attachment #9508344 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: Dropping of images into Finder on macOS would be broken (regression from bug 1802163)
  • Code covered by automated testing: no
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Drag any image from Firefox into Finder.
  • Risk associated with taking this patch: Minimal.
  • Explanation of risk level: This restores code and functionality that existed prior to the regression from bug 1802163.
  • String changes made/needed: none
  • Is Android affected?: no

https://hg.mozilla.org/mozilla-central/rev/7fed0a3528ef

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox144: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Attachment #9508344 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(spohl.mozilla.bugs)
See Also: → 1989600
No longer duplicate of this bug: 1983616
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: