Drag and drop images to finder broken
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr128 | --- | unaffected |
| firefox-esr140 | --- | unaffected |
| firefox142 | --- | unaffected |
| firefox143 | + | fixed |
| firefox144 | + | fixed |
People
(Reporter: jamienk, Assigned: spohl)
References
(Regression)
Details
(Keywords: dataloss, regression)
Attachments
(2 external files, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:143.0) Gecko/20100101 Firefox/143.0
Steps to reproduce:
Drag and drop an image to the Desktop (or any folder). This worked yesterday, broke today 2025-08-14 Mac Nightly
Actual results:
It acts like it will save (green + etc)
Expected results:
It should save the image where dropped
| Reporter | ||
Comment 1•1 year ago
|
||
pretty big deal as I thought it was saving. It just silently fails.
| Reporter | ||
Comment 2•1 year ago
|
||
Ran mozregression GUI (what a GREAT tool):
Got this hit:
Bug 1802163: Improve dragging of file URLs on macOS. r=mac-reviewers,mstange
Updated•1 year ago
|
Updated•1 year ago
|
Comment 3•1 year ago
|
||
:spohl, since you are the author of the regressor, bug 1802163, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 4•1 year ago
|
||
I'm unable to reproduce this at the moment. Could you please clarify what version of macOS that you're on? And can you provide a sample image that doesn't work for you? Thanks!
| Reporter | ||
Comment 5•1 year ago
|
||
I'm on Mac OS Monterey 12.7.6 (21H1320)
All images fail from all website when I drag and drop them into the Finder. See this video:
Dragging & Dropping links works and results in .webloc files
I also seem to be able to drag and drop text resulting in .textClipping files
| Assignee | ||
Comment 6•1 year ago
|
||
Thank you, I'm able to reproduce now. Looking into it!
Comment 8•1 year ago
|
||
Set release status flags based on info from the regressing bug 1802163
Updated•1 year ago
|
Comment 9•1 year ago
|
||
The bug is marked as tracked for firefox143 (beta) and tracked for firefox144 (nightly). However, the bug still has low severity.
:jstutte, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 10•1 year ago
|
||
I have this isolated and believe to have a fix. Will upload patch shortly.
| Assignee | ||
Comment 11•1 year ago
|
||
This reverts back to using the lower-level Pasteboard APIs to retrieve the paste location from the pasteboard when one is present. It turns out that Cocoa APIs are unable to retrieve the paste location. This patch also reintroduces support for kPasteboardTypeFileURLPromise, which seemed to be a no-op while working on bug 1802163 but is clearly used by apps such as Finder.
| Assignee | ||
Comment 12•1 year ago
|
||
This reverts back to using the lower-level Pasteboard APIs to retrieve the paste location from the pasteboard when one is present. It turns out that Cocoa APIs are unable to retrieve the paste location. This patch also reintroduces support for kPasteboardTypeFileURLPromise, which seemed to be a no-op while working on bug 1802163 but is clearly used by apps such as Finder.
Original Revision: https://phabricator.services.mozilla.com/D261840
Updated•1 year ago
|
Comment 13•1 year ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Dropping of images into Finder on macOS will be broken (regression)
- Code covered by automated testing: no
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: n/a
- Risk associated with taking this patch: Minimal.
- Explanation of risk level: This restores code and functionality that existed prior to the regression from bug 1802163.
- String changes made/needed: none
- Is Android affected?: no
Comment 14•1 year ago
|
||
Comment 15•1 year ago
|
||
Comment 16•1 year ago
|
||
Backed out for causing build bustages
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/widget/cocoa/nsCocoaWindow.mm:3880:79: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
Comment 17•1 year ago
|
||
Updated•1 year ago
|
| Assignee | ||
Comment 18•1 year ago
|
||
This reverts back to using the lower-level Pasteboard APIs to retrieve the paste location from the pasteboard when one is present. It turns out that Cocoa APIs are unable to retrieve the paste location. This patch also reintroduces support for kPasteboardTypeFileURLPromise, which seemed to be a no-op while working on bug 1802163 but is clearly used by apps such as Finder.
Original Revision: https://phabricator.services.mozilla.com/D261840
Updated•1 year ago
|
Comment 19•1 year ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Dropping of images into Finder on macOS would be broken (regression from bug 1802163)
- Code covered by automated testing: no
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Drag any image from Firefox into Finder.
- Risk associated with taking this patch: Minimal.
- Explanation of risk level: This restores code and functionality that existed prior to the regression from bug 1802163.
- String changes made/needed: none
- Is Android affected?: no
Comment 20•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 21•1 year ago
|
||
| uplift | ||
| Assignee | ||
Updated•1 year ago
|
Description
•