1803942 - 102.5.1 breaks HTML signature with remote image

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[KAM]

Attachment: broken-html-signature.png

Steps to reproduce:

Similar to this very old Bug 527581, our signatures that were working for years are now showing broken image icons. We can double click and hit OK and the images will appear.

Can share my entire signature HTML offline or privately if needed but this synthesized snippet from my full signature demonstrates the issue with just one image:

<div class="moz-signature"><table border="0" width="722" cellspacing="0" cellpadding="0"><tbody><tr><td style="width: 75px; height: 179px; text-align: center; vertical-align: top;line-height:2.8"><p><a href="https://www.pccc.com/"><img moz-do-not-send="false" src="https://raptoremailsecurity.com/wp-content/uploads/2021/02/PCCC-Logo-Vertical-Blue-200x200-1-e1612835350484.png" alt="PCCCLogo" style="margin-top: 10px; margin-bottom:10px;" width="75" height="75"></a></td></tr></tbody></table></div>

Actual results:

We were working normally, upgrade to 102.5.1 automatically occurred, after upgrade signatures with HTML images no longer work as expected/previously making us sad corporate minions.

Attached is the screenshot from hitting ctrl-n for a new message and then doubleclicking the broken image and clicking ok shows the image as expected.

Expected results:

Our glorious corporate logos should have been displayed for all the world to marvel.

Comment 1

[KAM]

Attachment: broken-html-signature-afterdoubleclickandok.png

This image just shows that double clicking on the broken image and clicking OK does work in case this is helpful finding the problem.

Comment 5

[Kai Engert [:KaiE:]]

Thanks for the report.

It looks like we have reasonable behavior when sending, the remote image is actually attached to the email, so on the recipient side, the image is still being shown (because showing attached message is fine).

The bug seems to be limited to not displaying the image while composing the email.

Comment 6

[Kai Engert [:KaiE:]]

Attachment: Bug 1803942 - Allow loading remote content in composer in the user-defined signature. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1803942 - add automated test for remote images in signatures. r=kaie

Comment 9

[Magnus Melin [:mkmelin]]

Can we get this landed for the merge later today?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/977d80b490cb
Allow loading remote content in composer in the user-defined signature. r=mkmelin
https://hg.mozilla.org/comm-central/rev/21ce17b95011
add automated test for remote images in signatures. r=kaie

Comment 11

[Kai Engert [:KaiE:]]

Comment on attachment 9306905 [details]
Bug 1803942 - Allow loading remote content in composer in the user-defined signature. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1788096
User impact if declined: users with an image/logo in their html footer will see a broken image icon
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low, change is limited to the code that inserts the footer into the composer window

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9306905 [details]
Bug 1803942 - Allow loading remote content in composer in the user-defined signature. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9306980 [details]
Bug 1803942 - add automated test for remote images in signatures. r=kaie

[Triage Comment]
Approved for esr102

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.6.1:
https://hg.mozilla.org/releases/comm-esr102/rev/d32644643806
https://hg.mozilla.org/releases/comm-esr102/rev/a1538bd32abb

Comment 15

[Wayne Mery (:wsmwk)]

Please don't remove tracking flags without explaination.

Comment 16

[KAM]

Hello, 102.6.1 did resolve the issue however I found a related bug that might warrant that this bug is re-opened.

Problem: the compose window doesn't show the signature from remote images when you switch accounts

Recreation: If you start a new message from an account and then change the from with the pulldown to an account with Remote HTML images, the compose window shows them as broken until you send the message.

Expectation: The composer would show remote images as it did prior to 102.5.1 even when switching the from while composing messages.

Comment 17

[Wayne Mery (:wsmwk)]

(In reply to KAM from comment #16)

Hello, 102.6.1 did resolve the issue however I found a related bug that might warrant that this bug is re-opened.

Please file a new bug report.

Comment 18

[Magnus Melin [:mkmelin]]

We have bug 1807200.