Closed
Bug 18133
Opened 25 years ago
Closed 25 years ago
[FEATURE][REGRESSION] some keyboard shortcuts aren't working
Categories
(Core :: XUL, defect, P1)
Core
XUL
Tracking
()
VERIFIED
FIXED
M13
People
(Reporter: Brade, Assigned: saari)
References
Details
Keyboard shortcuts used to work. They don't work today (or recently). I expect to type "Command-O" on a Macintosh and open a window. (browser or composer). I tested Windows and Macintosh.
Summary: keyboard shortcuts aren't working → [REGRESSION] keyboard shortcuts aren't working
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 1•25 years ago
|
||
Fixed. There are other problems in editor that seem to be content model consruction/broadcaster hookup related. The case you state works again.
Comment 2•25 years ago
|
||
did you check something in today or are you claiming this is already fixed now? Just wondering because 1999111608 builds do not show any fix.
Comment 3•25 years ago
|
||
i may have a fix for this. there was a XUL problem.
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Comment 5•25 years ago
|
||
Reopening so it stays on the proper radar. *I've noticed that the listeners don't even fire when you press Ctrl-O UNLESS you've already accessed one of those dialogs. Only then is onkeypress= and oncommand= echoed to the console -even though they stil don't work.
Updated•25 years ago
|
Resolution: FIXED → ---
Comment 7•25 years ago
|
||
clearing the fixed resolution
Updated•25 years ago
|
Priority: P3 → P2
Summary: [REGRESSION] keyboard shortcuts aren't working → [REGRESSION] some keyboard shortcuts aren't working
Target Milestone: M13
Comment 9•25 years ago
|
||
targetting p2 for m13, most work using today's comm opt bits, <MOD>-O and <MOD>-E seem to be the main exceptions.
Updated•25 years ago
|
Component: XP Toolkit/Widgets → XPMenus
QA Contact: claudius → sairuh
Comment 10•25 years ago
|
||
reassigning QA to me and updating component.
Assignee | ||
Comment 11•25 years ago
|
||
Menus need to be pulled down before things work. There are many variations of this bug floating around.
Assignee | ||
Updated•25 years ago
|
Priority: P2 → P1
Summary: [REGRESSION] some keyboard shortcuts aren't working → [FEATURE][REGRESSION] some keyboard shortcuts aren't working
Assignee | ||
Comment 12•25 years ago
|
||
Waterson, I'm going to make this the primary bug for all of the duplicates
Assignee | ||
Updated•25 years ago
|
Assignee: saari → waterson
Status: REOPENED → NEW
Assignee | ||
Comment 13•25 years ago
|
||
Waterson, I'm actually assigning this to you.
Assignee | ||
Comment 14•25 years ago
|
||
*** Bug 20271 has been marked as a duplicate of this bug. ***
Updated•25 years ago
|
Assignee: waterson → saari
Comment 15•25 years ago
|
||
you and hyatt are the ones banging around in the code now. don't give -me- the bug! it worked until, uh, *YOUR* focus and key binding landed!!!
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 16•25 years ago
|
||
Ok... So the only way I can see that Hyatt/myself could have broken this would have been with the keybindings loading later, when a key is pressed. Maybe we missed a step with hooking broadcasters up? I don't know that part of the code very well at all.
Comment 17•25 years ago
|
||
I believe this was fixed with my latest checkin.
Assignee | ||
Comment 18•25 years ago
|
||
No, it is still broken
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 19•25 years ago
|
||
This does indeed look to be fixed now. Command-O on mac brings up the file dialog. Command-N a new browser. I thought this was still broken because I'd been using Command-H for Home and that wasn't working. Turns out that is a problem in the XUL itself.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 20•25 years ago
|
||
verified as fix using mac comm bits from 2000-011310.
Comment 21•25 years ago
|
||
BULK MOVE: Changing component from XP Menus to XP Toolkit/Widgets: Menus. XP Menus component will be deleted.
Component: XPMenus → XP Toolkit/Widgets: Menus
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: bugzilla → xptoolkit.widgets
Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•