1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

It appears we can also replace the "identity-popup-custom-root-learn-more" XUL label with the moz-support-link component. See the relevant following links for more details:

• https://searchfox.org/mozilla-central/rev/02ff1234547a8097df4b07a0deb70dae49ac0d03/browser/components/controlcenter/content/identityPanel.inc.xhtml#130
• https://searchfox.org/mozilla-central/rev/02ff1234547a8097df4b07a0deb70dae49ac0d03/browser/base/content/browser-siteIdentity.js#935-938

Comment 1

[Ebilite Uchenna]

Hello TIms, can I work on this bug as an outreachy applicant

Comment 2

[Tim Giles [:tgiles]]

Ebilite, if you still want to help out, please comment again on this bug.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • The easiest way I've found to show all these elements in the user interface (UI) is the following:
     • Go to any website (say bugzilla.mozilla.org)
     • Open the browser toolbox and enable the "Disable Popup Auto-Hide" feature under the three dots/meatball/kebab menu
     • In the main urlbar, activate the lock icon to bring up the "Connection security for bugzilla.mozilla.org" popup. Thanks to the previous setting, this popup will not automatically close if you happen to move focus in the window.
     • Use the browser toolbox to inspect this popup and find one of the hidden <description> tags then disable the display:none rule under the :is([when-connection], [when-customroot], [when-mixedcontent], [when-ciphers], [when-httpsonlystatus]) selector
     • Now you should be able to find the "Learn more" link that is relevant to this bug (please only fix the "identify-popup-custom-root-learn-more" in this bug!)
   • Change this <label id="identify-popup-custom-root-learn-more" .../> link to a moz-support-link. View this patch to see how to use the moz-support-link markup
   • Remove the redundant code in browser-siteidentity.js after adding the moz-support-link
   • If, after changing the markup, the new moz-support-link does not work correctly in the places you have changed, please reach out to me as we may need to import the moz-support-link module in identity-popup.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test toolkit/components/passwordmgr --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 3

[Ebilite Uchenna]

Thanks a lot Tgiles
I'm very much interested to help out.

Comment 4

[Ebilite Uchenna]

Hello tgiles,

Have been held up with this bug instruction for a while now

1. The main urlbar of firefox is not responding, no matter the webpage I try to access. but it seems like the built in app are connecting well enough.

2. I cant see the lock Icon as you have instructed so as to bring up the "Connection security for bugzilla.mozilla.org" popup.

3. tried using vscode built in search option(also tried searchfox) to see if I can trace the file with id="identify-popup-custom-root-learn-more" but that also seem abortive.

Is there another method to access this issue or find where the file is located. or maybe a help in simplifying the approach

Comment 5

[Ebilite Uchenna]

Sorry for the last message tgiles,

Just followed the instruction carefully again and found out you left two links that show where the file I will work on is , and I overlooked.

Comment 6

[Ebilite Uchenna]

Attachment: Bug 1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r?tgiles

Comment 7

[Tim Giles [:tgiles]]

Attachment: Bug 1814266 - Migrate strings after removing learn more markup. r=#fluent-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e5ac07b53d9
Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod
https://hg.mozilla.org/integration/autoland/rev/fb7b697636ae
Migrate strings after removing learn more markup. r=fluent-reviewers,flod

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1814266) for causing failures in browser_identityPopup_focus.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fb7b697636ae968abfa733051af6fe72be63bd57&selectedTaskRun=ABbsbOxlQhKu2f5ewvsstQ.0

Log: https://treeherder.mozilla.org/logviewer?job_id=411519146&repo=autoland&lineNumber=7356

Backout: https://hg.mozilla.org/integration/autoland/rev/0fc6bad2adf90f969aa1cb7091bcf327c7bc7c9e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e85638cb4816
Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod
https://hg.mozilla.org/integration/autoland/rev/aae90ac7b419
Migrate strings after removing learn more markup. r=fluent-reviewers,flod

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e85638cb4816
https://hg.mozilla.org/mozilla-central/rev/aae90ac7b419