1826824 - The "Cross-site cookies" Learn more link is not keyboard navigable

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Tim Giles [:tgiles]]

Bug 1814270 added a moz-support-link to the permissions popup, specifically in the permission-popup-storage-access-permission-list-header. I did not realize it at the time, but html:a elements are not keyboard navigable in PanelMultiView elements. I didn't see any issue in Bug 1813077 because I only added the moz-support-link to a popupnotification element within a panel and not a panelmultiview element. Chalk it up to lack of experience with the PanelMultiView element and assuming that an HTMLAnchorElement would work as expected in the chrome.

Fixing this bug will allow Bug 1814261 and Bug 1814266 to land without causing further regression. Additionally, this will allow any future moz-support-link that gets added to a PanelMultiView element to work as expected.

I don't see this landing in Nightly 113, so we'll likely need to uplift to Beta 113 after I land a fix.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1813077

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1826824 - Enable <a> and <html:a> to be tab navigable in <panelview> elements. r=gijs,jamie

Since moz-support-link elements can be declared in markup or created
in JS, we needed to add two tags to the _makeNavigableTreeWalker
function. These tags, <html:a> and <a>, allow the moz-support-link to
be tab navigable when used within a <panelview> element.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:tgiles, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1813077

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/574c8c89220e
Enable <a> and <html:a> to be tab navigable in <panelview> elements. r=Gijs,Jamie

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/574c8c89220e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tgiles, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Tim Giles [:tgiles]]

Comment on attachment 9327594 [details]
Bug 1826824 - Enable <a> and <html:a> to be tab navigable in <panelview> elements. r=gijs,jamie

Beta/Release Uplift Approval Request

• User impact if declined: The "Cross-site cookies" learn more link in the permissions panel will not be navigable by keyboard.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is effectively a one-line change and is covered by automated tests. At worst, we make some additional anchors in <panelview> elements navigable by keyboard.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9327594 [details]
Bug 1826824 - Enable <a> and <html:a> to be tab navigable in <panelview> elements. r=gijs,jamie

Approved for 113 beta 4, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ecf5530ceea5