1814270 - Use moz-support-link for "permission-popup-storage-access-permission-learn-more" label

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

Looks like this "permission-popup-storage-access-permission-learn-more" label can also be replaced with moz-support-link. Should be a drop-in replacement once we figure out where to import the moz-support-link module. I'm guessing permissionPanel.inc.xhtml is not going to be the correct place. Might be tricky since this appears to be chrome code and I can't remember if we've figured out how to import these components into chrome code.

Anyway, here's the relevant spots I've seen so far:

• https://searchfox.org/mozilla-central/rev/02ff1234547a8097df4b07a0deb70dae49ac0d03/browser/components/controlcenter/content/permissionPanel.inc.xhtml#38-40
• https://searchfox.org/mozilla-central/rev/02ff1234547a8097df4b07a0deb70dae49ac0d03/browser/base/content/browser-sitePermissionPanel.js#18-21

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • The easiest way I've found to show this label in the user interface (UI) is the following:
     • In https://searchfox.org/mozilla-central/rev/3ba3d0a57b6419206f82f80cd6c30faf59397664/browser/themes/shared/controlcenter/panel.css#470-472, temporarily comment out the display:none rule for this selector
     • Go to https://permission.site/ and click on the Notifications button and then either block or allow notifications from this test site.
     • Open the browser toolbox and enable the "Disable Popup Auto-Hide" feature under the three dots/meatball/kebab menu
     • In the main urlbar, activate the message/SMS icon to bring up the "Permissions for permission.site" popup. Thanks to the previous setting, this popup will not automatically close if you happen to move focus in the window.
     • Now you should be able to find the "Learn more" link that is relevant to this bug (Cross-site cookies) (please only fix the "permission-popup-storage-access-permission-learn-more" in this bug!)
   • Change this <label id="permission-popup-storage-access-permission-learn-more" .../> link to a moz-support-link. View this patch to see how to use the moz-support-link markup
   • Remove the redundant code in browser-sitePermissionPanel.js after adding the moz-support-link
   • If, after changing the markup and removing the redundant code, the new moz-support-link does not work correctly in the placs you have changed, you will need to import the moz-support-link.
     • You will need to use window.ensureCustomElements("moz-support-link"); in the _initializePopup() function in browser-sitePermissionPanel.js
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/base/content/test/permissions --headless and by ensuring the link still goes to the correct URL before you made your changes. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 3

[Ganna]

Hi Tim! I would like to solve this issue.

Comment 4

[Ganna]

Attachment: Bug 1814270 - Use moz-support-link for permission-popup-storage-access-permission-learn-more label. r=tgiles

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaa215e5d448
Use moz-support-link for permission-popup-storage-access-permission-learn-more label. r=tgiles

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/aaa215e5d448