1815003 - [Tabs tray to Compose] Enable in Release

Status: VERIFIED FIXED

(Fenix :: Tabs, task, P2)

Comment 1

[Noah Bond [:007]]

Attachment: Bug 1815003 - Enable the Tabs Tray to Compose rewrite

Comment 2

[Noah Bond [:007]]

I've opened a patch before I go on some unexpected leave (in case someone from my team gets to this while I'm out), but do NOT land this until the Inactive Tabs CFR has landed and been verified by QA.

https://phabricator.services.mozilla.com/D207641
https://bugzilla.mozilla.org/show_bug.cgi?id=1816746

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4fa339d9721
Enable the Tabs Tray to Compose rewrite r=android-reviewers,gl

Comment 4

[tszentpeteri]

Backed out for causing lint fenix failures

• Backout link
• Push with failures
• Failure Log
• Failure line:

[task 2024-05-07T22:44:11.912Z] > Task :detekt FAILED
[task 2024-05-07T22:44:11.912Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt:53:9: composeTabsTray can be a `const val`. [MayBeConst]
[task 2024-05-07T22:44:11.912Z] 
[task 2024-05-07T22:44:11.912Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt - 5min debt
[task 2024-05-07T22:44:11.912Z] 	MayBeConst - [composeTabsTray can be a `const val`.] at /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt:53:9
[task 2024-05-07T22:44:11.912Z] 
[task 2024-05-07T22:44:11.912Z] Overall debt: 5min
[task 2024-05-07T22:44:11.912Z] 
[task 2024-05-07T22:44:11.912Z] style - 5min debt
[task 2024-05-07T22:44:11.912Z] 	MayBeConst - [composeTabsTray can be a `const val`.] at /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt:53:9
[task 2024-05-07T22:44:11.912Z] 
[task 2024-05-07T22:44:11.912Z] Overall debt: 5min
[task 2024-05-07T22:44:11.912Z] 
[task 2024-05-07T22:44:11.912Z] Complexity Report:
[task 2024-05-07T22:44:11.913Z] 	- 119,263 lines of code (loc)
[task 2024-05-07T22:44:11.913Z] 	- 88,181 source lines of code (sloc)
[task 2024-05-07T22:44:11.913Z] 	- 59,651 logical lines of code (lloc)
[task 2024-05-07T22:44:11.913Z] 	- 17,573 comment lines of code (cloc)
[task 2024-05-07T22:44:11.913Z] 	- 10,425 cyclomatic complexity (mcc)
[task 2024-05-07T22:44:11.913Z] 	- 5,435 cognitive complexity
[task 2024-05-07T22:44:11.913Z] 	- 1 number of total code smells
[task 2024-05-07T22:44:11.913Z] 	- 19% comment source ratio
[task 2024-05-07T22:44:11.913Z] 	- 174 mcc per 1,000 lloc
[task 2024-05-07T22:44:11.913Z] 	- 0 code smells per 1,000 lloc
[task 2024-05-07T22:44:11.913Z] 
[task 2024-05-07T22:44:11.913Z] Project Statistics:
[task 2024-05-07T22:44:11.913Z] 	- number of properties: 5343
[task 2024-05-07T22:44:11.913Z] 	- number of functions: 4525
[task 2024-05-07T22:44:11.913Z] 	- number of classes: 1621
[task 2024-05-07T22:44:11.913Z] 	- number of packages: 186
[task 2024-05-07T22:44:11.913Z] 	- number of kt files: 920
[task 2024-05-07T22:44:11.913Z] 
[task 2024-05-07T22:44:11.913Z] Successfully generated SARIF: a standard format for the output of static analysis tools at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.sarif
[task 2024-05-07T22:44:11.913Z] Successfully generated Checkstyle XML report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.xml
[task 2024-05-07T22:44:11.913Z] Successfully generated plain text report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.txt
[task 2024-05-07T22:44:11.913Z] Successfully generated HTML report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.html
[task 2024-05-07T22:44:11.913Z] Successfully generated Markdown report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.md
[task 2024-05-07T22:44:11.913Z] 
[task 2024-05-07T22:44:11.913Z] FAILURE: Build failed with an exception.
[task 2024-05-07T22:44:11.913Z] 
[task 2024-05-07T22:44:11.913Z] * What went wrong:
[task 2024-05-07T22:44:11.913Z] Execution failed for task ':detekt'.
[task 2024-05-07T22:44:11.913Z] > Analysis failed with 1 weighted issues.
[task 2024-05-07T22:44:11.913Z] 
[task 2024-05-07T22:44:11.913Z] * Try:
[task 2024-05-07T22:44:11.913Z] > Run with --stacktrace option to get the stack trace.
[task 2024-05-07T22:44:11.913Z] > Run with --info or --debug option to get more log output.
[task 2024-05-07T22:44:11.913Z] > Run with --scan to get full insights.
[task 2024-05-07T22:44:11.913Z] > Get more help at https://help.gradle.org.

Comment 5

[Noah Bond [:007]]

I've fixed the lint error and added it back to the landing queue.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1df40ba7c88
Enable the Tabs Tray to Compose rewrite r=android-reviewers,gl

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/d1df40ba7c88

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Hi Noah, is this something we will want to call out in release notes? Can you request a release note and fill out the form that comes up when you do, either here or in the main bug for the new feature? Thanks!

Comment 9

[Noah Bond [:007]]

(In reply to Liz Henry (:lizzard) (relman/hg->git project) from comment #8)

Hi Noah, is this something we will want to call out in release notes? Can you request a release note and fill out the form that comes up when you do, either here or in the main bug for the new feature? Thanks!

Hey Liz, this is enabling a UI rewrite of the Tabs Tray that will help stabilize the feature, but it's mostly under-the-hood technical changes. Would that be appropriate for release notes?

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Oh, probably not, I misunderstood and thought the feature was significantly changing. Thanks!

Comment 11

[Sören Hentzschel]

While the changes are mostly under the hood, the rewrite brings the ability to reorder private tabs. Before the rewrite, you could only reorder non-private tabs. This is a "new feature" that was requested a few times in the past. Maybe you want to mention that.

Comment 12

[Noah Bond [:007]]

I had completely forgotten that it wasn't possible to reorder private tabs in the original implementation of the Tabs Tray, so that would likely be a good callout.

Comment 13

[Noah Bond [:007]]

Flagging this ticket for QE for awareness. The Tabs Tray rewrite will be going live in 127.

Comment 14

[Lorand Janos]

The Tabs Tray to Compose rewrite is enabled by default on RC 127.0.

Devices used:

• Samsung Galaxy S23 Ultra (Android 14)
• Xiaomi Pad 5 (Android 13)
• Lenovo Tab TB-X606X (Android 10)
• LG G7 Fit (Android 9)
• Samsung Galaxy Tab A (Android 5.1.1)

Marking the ticket as verified on 127.