1816746 - [Tabs tray to Compose] Add the Inactive tabs CFR

Status: VERIFIED FIXED

(Fenix :: Tabs, task, P3)

Description

[Noah Bond [:007]]

The logic and UI lives in TabsTrayInactiveTabsOnboardingBinding

Comment 1

[Vlad Dreghici [:vdreghici]]

Leaving a comm here for updating this since Alex told me about the existence of this ticket while working on updating CFRs to be sticky and The Inactive Tabs CFR no longer points to the inactive tabs section. Working on the previous two tasks, I figured the best approach would be to migrate the inactive tabs as well, therefore working on this as well. Here is the link for the PR that adds the Compose inactive tabs CFR. For now, I would recommend waiting for the sticky CFR patch, and after that we should land the patch for Inactive Tabs.

Comment 2

[Noah Bond [:007]]

Attachment: Bug 1816746 - Add the Inactive Tabs CFR to the Tabs Tray rewrite

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/122fb98bff62
Add the Inactive Tabs CFR to the Tabs Tray rewrite r=android-reviewers,matt-tighe

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/122fb98bff62

Comment 5

[Mira Lobontiu (Android QA)]

Attachment: 1816746.mp4

The inactive tabs CFR is pointing at the Inactive tabs section, but, on rotation, 2 CFR's are displayed on the screen.
Tested on the latest Fenix Nightly 127.0a1 from 4/26, with a Samsung Galaxy S24 (Android 14).

This behavior is not reproducible with Oppo Find X3 Lite (Android 11).

Rahul, please take a look at this.
I'll try to get a logcat as well.

Comment 6

[Mira Lobontiu (Android QA)]

Attachment: logcat1816746.txt

Comment 7

[Rahul Sainani [:rsainani]]

Thanks Mira, That's a bug. I'll reopen this bug.

Comment 8

[Mira Lobontiu (Android QA)]

Closing this ticket, as Bug 1894120 was fixed and verified.
The double inactive tabs CFR is no longer reproducible.